fixes to polymer, gets tests back to a stable state

pkg/polymer/lib/src/loader.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /** Annotation used to automatically register polymer elements. */
 class CustomTag {
   final String tagName;
   const CustomTag(this.tagName);
@@ skipping 15 matching lines @@
  *      is null, first find all libraries that need to be loaded by scanning for
  *      HTML imports in the main document.
  *
  * The initialization on each library is a top-level function and annotated with
  * [initMethod].
  *
  * The urls in [libraries] can be absolute or relative to
  * `currentMirrorSystem().isolate.rootLibrary.uri`.
  */
 void initPolymer([List<String> libraries]) {
-  runMicrotask(() {
-    // DOM events don't yet go through microtasks, so we catch those here.
-    new Timer.periodic(new Duration(milliseconds: 125),
-        (_) => performMicrotaskCheckpoint());
+  // Note: we synchronously load all libraries because the script invoking
+  // this is run after all HTML imports are resolved.

[blois, 2013/10/21 21:08:12]

Should there be a check to validate that HTML imports are loaded by checking the
polyfill (or if not polyfilled, document.readyState)?

[Siggi Cherem (dart-lang), 2013/10/21 21:10:24]

Note that we are not using the polyfill for this - this part of the code is for
Dartium only. Maybe we should make a note of that too

[Jennifer Messerly, 2013/10/21 21:42:56]

Siggi do you mind following up and adding a comment?

[Siggi Cherem (dart-lang), 2013/10/21 21:48:03]

Not a problem

+  if (libraries == null) {
+    libraries = _discoverScripts(document, window.location.href);
+  }
+  // TODO(14262): Schedule a dummy microtask in the root Zone to prevent

[blois, 2013/10/21 21:08:12]

Still necessary?

[Jennifer Messerly, 2013/10/21 21:42:56]

nope.

+  // dart:html from getting it's Zones mixed up.
+  scheduleMicrotask(() {});
+  dirtyCheckZone().run(() => initPolymerOptimized(libraries));
+}
 
-    preventFlashOfUnstyledContent();
+/**
+ * Same as [initPolymer], but runs the version that is optimized for deployment
+ * to the internet. The biggest difference is it omits the [Zone] that
+ * automatically invokes [Observable.dirtyCheck], and the list of libraries must
+ * be supplied instead of being dynamically searched for at runtime.
+ */
+// TODO(jmesserly): change the Polymer build step to call this directly.
+void initPolymerOptimized(List<String> libraries) {

[Siggi Cherem (dart-lang), 2013/10/21 21:07:42]

mmm.. this might have to change slightly once I let people call initPolymer in
their code (init.dart is optional). My thought is to make the build step do some
setup first, but keep the original call to 'initPolymer', so it behaves like the
optimized version.

no need to do anything here, just a heads up that I'll be changing this shortly
=)

[Jennifer Messerly, 2013/10/21 21:42:56]

yeah, I expected it would change :)
just illustrating how we can skip the zone now.

+  preventFlashOfUnstyledContent();
 
-    // TODO(jmesserly): mdv should use initMdv instead of mdv.initialize.
-    mdv.initialize();
-    document.register(PolymerDeclaration._TAG, PolymerDeclaration);
+  // TODO(jmesserly): mdv should use initMdv instead of mdv.initialize.
+  mdv.initialize();
+  document.register(PolymerDeclaration._TAG, PolymerDeclaration);
 
-    // Note: we synchronously load all libraries because the script invoking
-    // this is run after all HTML imports are resolved.
-    if (libraries == null) {
-      libraries = _discoverScripts(document, window.location.href);
-    }
-    _loadLibraries(libraries);
-  });
+  _loadLibraries(libraries);
 }
 
 void _loadLibraries(libraries) {
   for (var lib in libraries) {
-    _loadLibrary(lib);
+    try {
+      _loadLibrary(lib);
+    } catch (e, s) {
+      // Deliver errors async, so if a single library fails it doesn't prevent
+      // other things from loading.
+      new Completer().completeError(e, s);
+    }
   }
-  Polymer._ready.complete();
+
+  customElementsReady.then((_) => Polymer._ready.complete());
 }
 
 /**
  * Walks the HTML import structure to discover all script tags that are
  * implicitly loaded.
  */
 List<String> _discoverScripts(Document doc, String baseUri,
     [Set<Document> seen, List<String> scripts]) {
   if (seen == null) seen = new Set<Document>();
   if (scripts == null) scripts = <String>[];
@@ skipping 134 matching lines @@
     print("warning: methods marked with @initMethod should take no "
         "arguments, ${method.simpleName} expects some.");
     return;
   }
   obj.invoke(method.simpleName, const []);
 }
 
 class _InitMethodAnnotation {
   const _InitMethodAnnotation();
 }