Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2982253002: Migrate test block 2 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by jcollins
Modified:
3 years, 5 months ago
Reviewers:
*Bob Nystrom, bkonyi
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 2 to Dart 2.0. No test changes needed, status-files only. BUG= R=bkonyi@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/dc12eeeedc72de922980fbcf4864836d1f8ab4cc

Patch Set 1 #

Patch Set 2 : Merge with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1836 lines) Patch
D tests/corelib/big_integer_parsed_div_rem_vm_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib/big_integer_parsed_mul_div_vm_test.dart View 1 chunk +0 lines, -804 lines 0 comments Download
M tests/corelib/corelib.status View 1 3 chunks +1 line, -5 lines 0 comments Download
A + tests/corelib_2/big_integer_parsed_div_rem_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/big_integer_parsed_mul_div_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 3 chunks +9 lines, -1 line 0 comments Download
D tests/corelib_strong/big_integer_parsed_div_rem_vm_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib_strong/big_integer_parsed_mul_div_vm_test.dart View 1 chunk +0 lines, -804 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jcollins
3 years, 5 months ago (2017-07-19 17:04:26 UTC) #4
bkonyi
LGTM! :)
3 years, 5 months ago (2017-07-19 17:27:40 UTC) #7
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-19 17:33:54 UTC) #8
jcollins
3 years, 5 months ago (2017-07-21 15:07:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc12eeeedc72de922980fbcf4864836d1f8ab4cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698