Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: milo/frontend/view_config.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)
Patch Set: Rebase fixes and Working Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/frontend/appengine/templates/pages/configs.html ('k') | milo/frontend/view_console.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/frontend/view_config.go
diff --git a/milo/frontend/view_config.go b/milo/frontend/view_config.go
index fe6c391b44695bf31fb208d9cb353420965e50c6..97970163406bb6bcbcb8d7b492844a8723c21aa6 100644
--- a/milo/frontend/view_config.go
+++ b/milo/frontend/view_config.go
@@ -29,7 +29,7 @@ import (
// ConfigsHandler renders the page showing the currently loaded set of luci-configs.
func ConfigsHandler(c *router.Context) {
- projects, err := common.GetAllProjects(c.Context)
+ consoles, err := common.GetAllConsoles(c.Context, "")
if err != nil {
ErrorHandler(c, errors.Annotate(err, "Error while getting projects").Err())
return
@@ -41,7 +41,7 @@ func ConfigsHandler(c *router.Context) {
}
templates.MustRender(c.Context, c.Writer, "pages/configs.html", templates.Args{
- "Projects": projects,
+ "Consoles": consoles,
"ServiceConfig": sc,
})
}
@@ -51,7 +51,7 @@ func UpdateConfigHandler(ctx *router.Context) {
c, h := ctx.Context, ctx.Writer
// Needed to access the PubSub API
c = appengine.WithContext(c, ctx.Request)
- projErr := common.UpdateProjectConfigs(c)
+ projErr := common.UpdateConsoles(c)
if projErr != nil {
logging.WithError(projErr).Errorf(c, "project update handler encountered error")
}
« no previous file with comments | « milo/frontend/appengine/templates/pages/configs.html ('k') | milo/frontend/view_console.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698