Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: milo/common/config_test.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)
Patch Set: Rebase fixes and Working Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/common/config.go ('k') | milo/frontend/appengine/templates/pages/configs.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/common/config_test.go
diff --git a/milo/common/config_test.go b/milo/common/config_test.go
index ee1863b589a0d89df935ce48a76bc13d78e6ba27..89260f3f314b586165513230ef3784a3f552435c 100644
--- a/milo/common/config_test.go
+++ b/milo/common/config_test.go
@@ -61,19 +61,12 @@ func TestConfig(t *testing.T) {
_, err := UpdateServiceConfig(c)
So(err, ShouldBeNil)
// Send update here
- err = UpdateProjectConfigs(c)
- So(err, ShouldBeNil)
-
- Convey("Check Project config updated", func() {
- p, err := GetProject(c, "foo")
- So(err, ShouldBeNil)
- So(p.ID, ShouldEqual, "foo")
- })
+ So(UpdateConsoles(c), ShouldBeNil)
Convey("Check Console config updated", func() {
cs, err := GetConsole(c, "foo", "default")
So(err, ShouldBeNil)
- So(cs.Name, ShouldEqual, "default")
+ So(cs.ID, ShouldEqual, "default")
So(cs.RepoURL, ShouldEqual, "https://chromium.googlesource.com/foo/bar")
})
})
@@ -83,9 +76,9 @@ func TestConfig(t *testing.T) {
var fooCfg = `
ID: "foo"
Consoles: {
- Name: "default"
+ ID: "default"
RepoURL: "https://chromium.googlesource.com/foo/bar"
- Branch: "master"
+ Ref: "master"
Builders: {
Name: "buildbucket/luci.foo.something/bar"
Category: "main|something"
« no previous file with comments | « milo/common/config.go ('k') | milo/frontend/appengine/templates/pages/configs.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698