Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: milo/api/resp/build.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)
Patch Set: Rebase fixes and Working Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/api/config/project.pb.go ('k') | milo/buildsource/buildbot/pubsub_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/api/resp/build.go
diff --git a/milo/api/resp/build.go b/milo/api/resp/build.go
index b316f18f855f499730eef2cebbc5559963db1841..174f328f23bcb78db9c004d9d3f524c70170d9aa 100644
--- a/milo/api/resp/build.go
+++ b/milo/api/resp/build.go
@@ -315,7 +315,7 @@ func (rb *MiloBuild) SummarizeTo(c context.Context, bs *model.BuildSummary) erro
Name: "REVISION",
ID: []byte(rb.SourceStamp.Revision.Label),
})
- consoles, err := common.GetConsolesForBuilder(c, bs.BuilderID)
+ consoles, err := common.GetAllConsoles(c, bs.BuilderID)
if err != nil {
return err
}
@@ -324,7 +324,7 @@ func (rb *MiloBuild) SummarizeTo(c context.Context, bs *model.BuildSummary) erro
// definitions will specify their manifest as "REVISION", and we'll do
// lookups with null URL fields.
bs.AddManifestKey(
- con.ProjectID, con.Console.Name, "REVISION", "", revisionBytes)
+ con.GetProjectName(), con.ID, "REVISION", "", revisionBytes)
}
}
}
« no previous file with comments | « milo/api/config/project.pb.go ('k') | milo/buildsource/buildbot/pubsub_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698