Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: milo/api/resp/build.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)
Patch Set: Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/api/resp/build.go
diff --git a/milo/api/resp/build.go b/milo/api/resp/build.go
index 1cf550d120f6338d16d7dbb24ac4c38e93e931fa..2b450f696d669a408bf3374810a077d421ed2508 100644
--- a/milo/api/resp/build.go
+++ b/milo/api/resp/build.go
@@ -304,7 +304,7 @@ func (rb *MiloBuild) SummarizeTo(c context.Context, bs *model.BuildSummary) erro
Name: "REVISION",
ID: []byte(rb.SourceStamp.Revision.Label),
})
- consoles, err := common.GetConsolesForBuilder(c, bs.BuilderID)
+ consoles, err := common.GetAllConsoles(c, bs.BuilderID)
if err != nil {
return err
}
@@ -313,7 +313,7 @@ func (rb *MiloBuild) SummarizeTo(c context.Context, bs *model.BuildSummary) erro
// definitions will specify their manifest as "REVISION", and we'll do
// lookups with null URL fields.
bs.AddManifestRevisionIndex(
- con.ProjectID, con.Console.Name, "REVISION", "", revisionBytes)
+ con.GetProjectName(), con.ID, "REVISION", "", revisionBytes)
}
}
}

Powered by Google App Engine
This is Rietveld 408576698