Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: milo/api/resp/build.go

Issue 2982183002: Milo: Store console defs as their own entities (Closed)
Patch Set: tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The LUCI Authors. 1 // Copyright 2015 The LUCI Authors.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 }) 306 })
307 consoles, err := common.GetConsolesForBuilder(c, bs.BuilderID) 307 consoles, err := common.GetConsolesForBuilder(c, bs.BuilderID)
308 if err != nil { 308 if err != nil {
309 return err 309 return err
310 } 310 }
311 for _, con := range consoles { 311 for _, con := range consoles {
312 // HACK(iannucci): Until we have real ma nifest support, console 312 // HACK(iannucci): Until we have real ma nifest support, console
313 // definitions will specify their manife st as "REVISION", and we'll do 313 // definitions will specify their manife st as "REVISION", and we'll do
314 // lookups with null URL fields. 314 // lookups with null URL fields.
315 bs.AddManifestRevisionIndex( 315 bs.AddManifestRevisionIndex(
316 » » » » » » con.ProjectID, con.Console.Name, "REVISION", "", revisionBytes) 316 » » » » » » con.GetProjectName(), con.ID, "R EVISION", "", revisionBytes)
317 } 317 }
318 } 318 }
319 } 319 }
320 if rb.SourceStamp.Changelist != nil { 320 if rb.SourceStamp.Changelist != nil {
321 bs.Patches = append(bs.Patches, model.PatchInfo{ 321 bs.Patches = append(bs.Patches, model.PatchInfo{
322 Link: rb.SourceStamp.Changelist.Link, 322 Link: rb.SourceStamp.Changelist.Link,
323 AuthorEmail: rb.SourceStamp.AuthorEmail, 323 AuthorEmail: rb.SourceStamp.AuthorEmail,
324 }) 324 })
325 } 325 }
326 } 326 }
327 return nil 327 return nil
328 } 328 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698