Unifying compiler context

pkg/front_end/lib/src/incremental/kernel_driver.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:front_end/file_system.dart';
+import 'package:front_end/compiler_options.dart';
 import 'package:front_end/src/base/api_signature.dart';
+import 'package:front_end/src/base/processed_options.dart';
 import 'package:front_end/src/base/performace_logger.dart';
-import 'package:front_end/src/fasta/compiler_command_line.dart';
 import 'package:front_end/src/fasta/compiler_context.dart';
 import 'package:front_end/src/fasta/dill/dill_library_builder.dart';
 import 'package:front_end/src/fasta/dill/dill_target.dart';
 import 'package:front_end/src/fasta/kernel/kernel_target.dart';
 import 'package:front_end/src/fasta/kernel/utils.dart';
 import 'package:front_end/src/fasta/ticker.dart';
 import 'package:front_end/src/fasta/uri_translator.dart';
 import 'package:front_end/src/incremental/byte_store.dart';
 import 'package:front_end/src/incremental/file_state.dart';
 import 'package:kernel/binary/ast_from_binary.dart';
@@ skipping 121 matching lines @@
               await _compileCycle(nameRoot, dillTarget, cycle);
           results.add(result);
         }
       });
 
       return new KernelResult(nameRoot, results);
     });
   }
 
   Future<T> runWithFrontEndContext<T>(String msg, Future<T> f()) async {
-    return await CompilerCommandLine.withGlobalOptions("", [""],
-        (CompilerContext context) {
-      context.options.options["--target"] = _target;
-      context.options.options["report"] = (message, severity) {};
-      context.options.options["reportWithoutLocation"] = (message, severity) {};
-      return _logger.runAsync(msg, f);
-    });
+    var options = new CompilerOptions()
+      ..target = _target
+      ..reportMessages = false; // ignore errors.

[ahe, 2017/07/18 16:54:37]

Seems like we need a TODO or an explanation why we should ignore errors.

[Siggi Cherem (dart-lang), 2017/07/18 22:50:44]

Done.

+    return await CompilerContext.runWithOptions(
+        new ProcessedOptions(options), (_) => _logger.runAsync(msg, f));
   }
 
   /// The file with the given [uri] might have changed - updated, added, or
   /// removed. Or not, we don't know. Or it might have, but then changed back.
   ///
   /// The [uri] must be absolute and normalized file URI.
   ///
   /// Schedules the file contents for the [uri] to be read into the current
   /// file state prior the next invocation of [getKernel] returns the result.
   ///
@@ skipping 200 matching lines @@
 
   LibraryCycleResult(this.cycle, this.signature, this.kernelLibraries);
 }
 
 @visibleForTesting
 class _TestView {
   /// The list of [LibraryCycle]s compiled for the last delta.
   /// It does not include libraries which were read from the cache.
   final List<LibraryCycle> compiledCycles = [];
 }