Unifying compiler context

utils/kernel-service/kernel-service.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This is an interface to the Dart Kernel parser and Kernel binary generator.
 ///
 /// It is used by the kernel-isolate to load Dart source code and generate
 /// Kernel binary format.
 ///
 /// This is either invoked as the root script of the Kernel isolate when used
@@ skipping 60 matching lines @@
   }
 
   var errors = <String>[];
   var options = new CompilerOptions()
     ..strongMode = strongMode
     ..fileSystem = fileSystem
     ..target = new VmFastaTarget(new TargetFlags(strongMode: strongMode))
     ..packagesFileUri = packagesUri
     ..sdkSummary = sdkSummary
     ..verbose = verbose
-    ..onError = (CompilationError e) => errors.add(e.message);
+    ..throwOnErrors = false
+    ..reportMessages = true
+    ..onError = (CompilationMessage e) {
+      if (e.severity == Severity.error) {
+        // TODO(sigmund): support emitting code with errors as long as they are
+        // handled in the generated code (issue #30194).
+        errors.add(e.message);
+      }
+    };
 
   CompilationResult result;
   try {
     Program program = await kernelForProgram(script, options);
     if (errors.isNotEmpty) {
+      // TODO(sigmund): the compiler prints errors to the console, so we
+      // shouldn't print those messages again here.
       result = new CompilationResult.errors(errors);
     } else {
       // We serialize the program excluding platform.dill because the VM has
       // these sources built-in. Everything loaded as a summary in
       // [kernelForProgram] is marked `external`, so we can use that bit to
       // decide what to excluce.
       // TODO(sigmund): remove the following line (Issue #30111)
       program.libraries.forEach((e) => e.isExternal = false);
       result = new CompilationResult.ok(
           serializeProgram(program, filter: (lib) => !lib.isExternal));
@@ skipping 144 matching lines @@
   _CompilationCrash(this.exception, this.stack);
 
   @override
   Status get status => Status.crash;
 
   @override
   String get errorString => "${exception}\n${stack}";
 
   String toString() => "_CompilationCrash(${errorString})";
 }