Unifying compiler context

pkg/front_end/lib/compiler_options.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library front_end.compiler_options;
 
 import 'package:front_end/src/base/performace_logger.dart';
 import 'package:front_end/src/incremental/byte_store.dart';
 import 'package:kernel/target/targets.dart' show Target;
 
-import 'compilation_error.dart';
+import 'compilation_message.dart';
 import 'file_system.dart';
 import 'physical_file_system.dart';
 
-/// Default error handler used by [CompilerOptions.onError].
-void defaultErrorHandler(CompilationError error) => throw error;
-
 /// Callback used to report errors encountered during compilation.
-typedef void ErrorHandler(CompilationError error);
+typedef void ErrorHandler(CompilationMessage error);
 
 /// Front-end options relevant to compiler back ends.
 ///
 /// Not intended to be implemented or extended by clients.
 class CompilerOptions {
   /// The URI of the root of the Dart SDK (typically a "file:" URI).
   ///
   /// If `null`, the SDK will be searched for using
   /// [Platform.resolvedExecutable] as a starting point.
   Uri sdkRoot;
 
   /// Map of `dart:*` libraries to URIs in the [fileSystem].
   ///
   /// Keys in the map are the name of the library with no `dart:` prefix, for
   /// example:
   ///
   ///      {'core': 'file:///sdk/lib/core/core.dart'}
   ///
   /// If `null`, the default set of libraries will be loaded from
   /// `sdkRoot/lib/libraries.json`.
   // TODO(sigmund): also provide an option to specify the .json file, then
   // consider dropping this option.
   Map<String, Uri> dartLibraries;
 
   /// Callback to which compilation errors should be delivered.
   ///
-  /// By default, the first error will be reported by throwing an exception of
-  /// type [CompilationError].
-  ErrorHandler onError = defaultErrorHandler;
+  /// By default, when no callback is provided, the compiler will report
+  /// messages on the console and will throw when fatal errors are discovered.
+  ErrorHandler onError;
+
+  /// Whether messages should be reported using the compiler's internal
+  /// reporting mechanism.
+  ///
+  /// If no [onError] handler is provided, the default is true. If an [onError]
+  /// handler is provided, the default is false. Setting this to true will
+  /// ensure that error messages are printed in the console and that fatal
+  /// errors cause an exception.
+  // TODO(sigmund): add also an API for formatting errors and provide a default
+  // formatter. This way user can configure error style in the console and in
+  // generated code that contains error messages.
+  bool reportMessages;
 
   /// URI of the ".packages" file (typically a "file:" URI).
   ///
   /// If `null`, the ".packages" file will be found via the standard
   /// package_config search algorithm.
   ///
   /// If the URI's path component is empty (e.g. `new Uri()`), no packages file
   /// will be used.
   Uri packagesFileUri;
 
@@ skipping 131 matching lines @@
 
   /// Whether to dump generated programs in a text format (also mainly for
   /// debugging).
   ///
   /// Dumped data is printed in stdout.
   bool debugDump = false;
 
   /// Whether to set the exit code to non-zero if any problem (including
   /// warning, etc.) is encountered during compilation.
   bool setExitCodeOnProblem = false;
+
+  /// Whether to embed the input sources in generated kernel programs.
+  ///
+  /// The kernel `Program` API includes a `uriToSource` map field that is used
+  /// to embed the entire contents of the source files. This part of the kernel
+  /// API is in flux and it is not necessary for some tools. Today it is used
+  /// for translating error locations and stack traces in the VM.
+  // TODO(sigmund): change the default.
+  bool embedSourceText = true;
+
+  /// Whether the compiler should throw as soon as it encounters a
+  /// compilation error.
+  // TODO(sigmund): change the default (issue #30194).
+  bool throwOnErrors = true;
+
+  /// Whether the compiler should throw as soon as it encounters a
+  /// compilation warning.
+  ///
+  /// Typically used by developers to debug internals of the compiler.
+  bool throwOnWarnings = false;
+
+  /// Whether the compiler should throw as soon as it encounters a
+  /// compilation nit.
+  ///
+  /// Typically used by developers to debug internals of the compiler.
+  bool throwOnNits = false;
 }