Added presubmit checks for tests.

Added checks for tests.

PRESUBMIT will check:
  1. a new test can NOT be added to Dart 1.0 the new test can only be added to DDC.
  2. a existing Dart 1.0 test changed must have its corresponding DDC test updated too (if it exists).

Presubmit errors may appear as:

** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC  test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC  test must change: tests/language_2/compiler_annotations.dart

R=jacobr@google.com, rnystrom@google.com

Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0  test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0  test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart
Committed: https://github.com/dart-lang/sdk/commit/0afa1428a112aad0bc06c1689591c88a30424dd5

[terry, 2017-07-17 13:27:15]

Description was changed from

==========
Added checks for tests.

R=rnystrom@google.com
==========

to

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too.

R=rnystrom@google.com
==========

[terry, 2017-07-17 18:33:23]

Description was changed from

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too.

R=rnystrom@google.com
==========

to

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too.

R=rnystrom@google.com,jacobr@google.com
==========

[terry, 2017-07-17 18:34:25]

Description was changed from

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too.

R=rnystrom@google.com,jacobr@google.com
==========

to

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too (if it exists).

R=rnystrom@google.com,jacobr@google.com
==========

[terry, 2017-07-17 20:02:24]

terry@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2017-07-17 20:16:34]

looks nice! a few minor comments.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode116
PRESUBMIT.py:116: for f in input_api.AffectedFiles():
Indentation seems strange. Ident two spaces by default

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode117
PRESUBMIT.py:117: if old_locations.match(f.LocalPath()):
I believe you should be able to match relative to the repository route instead
of having to match url substrings.
If you manage that then you can avoid the regex match and just check for dart 1
test directories directly.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode152
PRESUBMIT.py:152: 'Error: New Dart 1.0 test can not be added the test must be
added '
maybe remind users where the dart 2.0 test should go?

[Bob Nystrom, 2017-07-17 20:38:24]

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode103
PRESUBMIT.py:103: #    Dart 1 tests                Dart 2.0 tests
I would say "DDC tests" instead of "Dart 2.0", since the migrated 2.0 tests will
be in the "_2" directories, not the "_strong" ones.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode139
PRESUBMIT.py:139: break;
No ";" in Python. :)

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode147
PRESUBMIT.py:147: 'test too.\n'
How about:

"If you change a Dart 1.0 test, you must also update the DDC fork of it."

It would be good to show both the 1.0 and DDC paths of the file they need to
fix.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode152
PRESUBMIT.py:152: 'Error: New Dart 1.0 test can not be added the test must be
added '
On 2017/07/17 20:16:34, Jacob wrote:
> maybe remind users where the dart 2.0 test should go?

+1.

It will be the same as the DDC path but with "_2" instead of "_strong".

[terry, 2017-07-18 13:48:39]

Description was changed from

==========
Added checks for tests.

PRESUBMIT will check:
  1. new test can NOT be added to Dart 1.0 the new test can only be added to
Dart 2.0.
  2. existing Dart 1.0 test changed must have its corresponding Dart 2.0 test
updated too (if it exists).

R=rnystrom@google.com,jacobr@google.com
==========

to

==========
Added checks for tests.

PRESUBMIT will check:
  1. a new test can NOT be added to Dart 1.0 the new test can only be added to
DDC.
  2. a existing Dart 1.0 test changed must have its corresponding DDC test
updated too (if it exists).

Presubmit errors may appear as:

** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC  test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC  test must change: tests/language_2/compiler_annotations.dart

Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0  test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0  test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart



R=rnystrom@google.com,jacobr@google.com
==========

[terry, 2017-07-18 13:48:50]

PTAL

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode103
PRESUBMIT.py:103: #    Dart 1 tests                Dart 2.0 tests
On 2017/07/17 20:38:23, Bob Nystrom wrote:
> I would say "DDC tests" instead of "Dart 2.0", since the migrated 2.0 tests
will
> be in the "_2" directories, not the "_strong" ones.

Done.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode116
PRESUBMIT.py:116: for f in input_api.AffectedFiles():
On 2017/07/17 20:16:34, Jacob wrote:
> Indentation seems strange. Ident two spaces by default

Yes didn't notice that the 2 functions have different indents.  Changed the new
one and the old one to be 2 space indents.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode116
PRESUBMIT.py:116: for f in input_api.AffectedFiles():
On 2017/07/17 20:16:34, Jacob wrote:
> Indentation seems strange. Ident two spaces by default

Acknowledged.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode116
PRESUBMIT.py:116: for f in input_api.AffectedFiles():
On 2017/07/17 20:16:34, Jacob wrote:
> Indentation seems strange. Ident two spaces by default

Done.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode117
PRESUBMIT.py:117: if old_locations.match(f.LocalPath()):
On 2017/07/17 20:16:34, Jacob wrote:
> I believe you should be able to match relative to the repository route instead
> of having to match url substrings.
> If you manage that then you can avoid the regex match and just check for dart
1
> test directories directly.

Done.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode139
PRESUBMIT.py:139: break;
On 2017/07/17 20:38:24, Bob Nystrom wrote:
> No ";" in Python. :)

Done.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode147
PRESUBMIT.py:147: 'test too.\n'
On 2017/07/17 20:38:23, Bob Nystrom wrote:
> How about:
> 
> "If you change a Dart 1.0 test, you must also update the DDC fork of it."
> 
> It would be good to show both the 1.0 and DDC paths of the file they need to
> fix.

Done.

https://codereview.chromium.org/2982043002/diff/20001/PRESUBMIT.py#newcode152
PRESUBMIT.py:152: 'Error: New Dart 1.0 test can not be added the test must be
added '
On 2017/07/17 20:16:34, Jacob wrote:
> maybe remind users where the dart 2.0 test should go?

Done.

[Jacob, 2017-07-18 15:00:42]

lgtm

[terry, 2017-07-18 15:20:49]

Description was changed from

==========
Added checks for tests.

PRESUBMIT will check:
  1. a new test can NOT be added to Dart 1.0 the new test can only be added to
DDC.
  2. a existing Dart 1.0 test changed must have its corresponding DDC test
updated too (if it exists).

Presubmit errors may appear as:

** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC  test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC  test must change: tests/language_2/compiler_annotations.dart

Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0  test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0  test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart



R=rnystrom@google.com,jacobr@google.com
==========

to

==========
Added checks for tests.

PRESUBMIT will check:
  1. a new test can NOT be added to Dart 1.0 the new test can only be added to
DDC.
  2. a existing Dart 1.0 test changed must have its corresponding DDC test
updated too (if it exists).

Presubmit errors may appear as:

** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC  test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC  test must change: tests/language_2/compiler_annotations.dart

R=jacobr@google.com, rnystrom@google.com

Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0  test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0  test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart
Committed:
https://github.com/dart-lang/sdk/commit/0afa1428a112aad0bc06c1689591c88a30424dd5
==========

[terry, 2017-07-18 15:20:50]

Committed patchset #11 (id:190001) manually as
0afa1428a112aad0bc06c1689591c88a30424dd5 (presubmit successful).