Issue 2981943002: Resynthesize top-level variables from Kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2981943002: Resynthesize top-level variables from Kernel. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Resynthesize top-level variables from Kernel. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8a98f240a9672edfda94713bb2151346bd576238

Patch Set 1 #

Total comments: 1

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -42 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	9 chunks	+53 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/element_text.dart	View	1 chunk	+11 lines, -0 lines	1 comment	Download
M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View	9 chunks	+16 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/2981943002/diff/1/pkg/analyzer/test/src/summary/element_text.dart File pkg/analyzer/test/src/summary/element_text.dart (right): https://codereview.chromium.org/2981943002/diff/1/pkg/analyzer/test/src/summary/element_text.dart#newcode705 pkg/analyzer/test/src/summary/element_text.dart:705: } Consider adding: else { expect(e.setter, isNull); }

3 years, 5 months ago (2017-07-15 15:33:17 UTC) #2

scheglov

3 years, 5 months ago (2017-07-15 17:06:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a98f240a9672edfda94713bb2151346bd576238 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages