Issue 298193002: Revert of ChromeOS login webui refactoring: split user selection/gaia login screens.

Issue 298193002: Revert of ChromeOS login webui refactoring: split user selection/gaia login screens. (Closed)

Created:
6 years, 7 months ago by sergeyv

Modified:
6 years, 7 months ago

Reviewers:
Denis Kuznetsov (DE-MUC), Nikita (slow)

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of ChromeOS login webui refactoring: split user selection/gaia login screens. (https://codereview.chromium.org/293613003/) Reason for revert: Speculative Revert: looks like it can cause failure on chromium.chromiumos: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29&number=10843 Original issue's description: > ChromeOS login webui refactoring: split user selection/gaia login screens. > Phase one : introduce future screen classes before moving code from handler. > > BUG=373314 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272870 TBR=nkostylev@chromium.org,antrim@chromium.org NOTREECHECKS=true NOTRY=true BUG=373314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272944

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -198 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View	4 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/core_oobe_actor.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	chrome/browser/chromeos/login/screens/gaia_screen.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/chromeos/login/screens/gaia_screen.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/browser/chromeos/login/screens/user_selection_screen.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/browser/chromeos/login/screens/user_selection_screen.cc	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_display.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/mock_login_display.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.cc	View	7 chunks	+37 lines, -32 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/login_common.js	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sergeyv

Created Revert of ChromeOS login webui refactoring: split user selection/gaia login screens.

6 years, 7 months ago (2014-05-27 11:15:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/298193002/1

6 years, 7 months ago (2014-05-27 11:16:31 UTC) #2

Message was sent while issue was closed.

Change committed as 272944

Expand Messages | Collapse Messages