Move `reify` to use fasta instead of dartk

Move `reify` to use fasta instead of dartk

Note the suite seemed to have a lot of tests crashing in verification.

With my change I'm noting other crashes, but I haven't investigated where they are from.

Also, to run the suite, before it used to be run as:

  dart pkg/kernel/test/reify/suite.dart

Now it needs to be run as:
  DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart pkg/kernel/test/reify/suite.dart

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ad4f985afeac9db83ee7f0b51f269215ad2779a

[Siggi Cherem (dart-lang), 2017-07-13 22:19:22]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-13 22:21:13]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-13 22:22:29]

https://codereview.chromium.org/2981813002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/testing/kernel_chain.dart (right):

https://codereview.chromium.org/2981813002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/testing/kernel_chain.dart:205: // Do not link
platform.dill, but recompile the platform libraries. This
BTW - I want to change that about how we include stuff in platform.dill. It
should not be defined by target IMO, but by providing a list of libraries when
compiling a platform.

[Siggi Cherem (dart-lang), 2017-07-13 22:23:53]

Description was changed from

==========
Move `reify` to use fasta instead of dartk

BUG=
==========

to

==========
Move `reify` to use fasta instead of dartk

Note the suite seemed to have a lot of tests crashing in verification.

With my change I'm noting other crashes, but I haven't investigated where they
are from.

Also, to run the suite, before it used to be run as:

  dart pkg/kernel/test/reify/suite.dart

Now it needs to be run as:
  DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart
pkg/kernel/test/reify/suite.dart

BUG=
==========

[Siggi Cherem (dart-lang), 2017-07-14 17:24:47]

sigmund@google.com changed reviewers:
+ paulberry@google.com

[Siggi Cherem (dart-lang), 2017-07-14 17:24:48]

This is to get to the point where we can delete some of the support for the old
dartk.

I filed https://github.com/dart-lang/sdk/issues/30166 to track that these tests
are currently crashing.

[Paul Berry, 2017-07-14 21:57:22]

lgtm

[Siggi Cherem (dart-lang), 2017-07-14 22:04:48]

Description was changed from

==========
Move `reify` to use fasta instead of dartk

Note the suite seemed to have a lot of tests crashing in verification.

With my change I'm noting other crashes, but I haven't investigated where they
are from.

Also, to run the suite, before it used to be run as:

  dart pkg/kernel/test/reify/suite.dart

Now it needs to be run as:
  DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart
pkg/kernel/test/reify/suite.dart

BUG=
==========

to

==========
Move `reify` to use fasta instead of dartk

Note the suite seemed to have a lot of tests crashing in verification.

With my change I'm noting other crashes, but I haven't investigated where they
are from.

Also, to run the suite, before it used to be run as:

  dart pkg/kernel/test/reify/suite.dart

Now it needs to be run as:
  DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart
pkg/kernel/test/reify/suite.dart

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4ad4f985afeac9db83ee7f0b51f269215ad2779a
==========

[Siggi Cherem (dart-lang), 2017-07-14 22:04:50]

Committed patchset #2 (id:60001) manually as
4ad4f985afeac9db83ee7f0b51f269215ad2779a (presubmit successful).