Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2981773002: [Windows] Turn off TLS destructors in the Platform exception handler (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
alexmarkov
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Windows] Turn off TLS destructors in the Platform exception handler R=alexmarkov@google.com Committed: https://github.com/dart-lang/sdk/commit/0148dfce032e1ae48d8551d9713dc9718a989af9

Patch Set 1 #

Patch Set 2 : Fix error code type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/bin/platform_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 5 months ago (2017-07-13 20:00:16 UTC) #2
alexmarkov
lgtm
3 years, 5 months ago (2017-07-13 20:00:49 UTC) #3
zra
3 years, 5 months ago (2017-07-13 20:04:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0148dfce032e1ae48d8551d9713dc9718a989af9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698