Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: pkg/analyzer/lib/src/fasta/analyzer_loader.dart

Issue 2981693002: Start copying resolution/inference data from front end to analyzer ASTs. (Closed)
Patch Set: Address code review comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/fasta/analyzer_loader.dart
diff --git a/pkg/analyzer/lib/src/fasta/analyzer_loader.dart b/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
index 3c7554bac580654cd9418af3da7a9438bedfaab0..169634b0e27fe1a9ebd9d8cd5dff62a3f2968cd2 100644
--- a/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
+++ b/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
@@ -28,7 +28,30 @@ import 'package:kernel/src/incremental_class_hierarchy.dart';
class AnalyzerLoader<L> extends SourceLoader<L> {
ElementStore elementStore;
- AnalyzerLoader(TargetImplementation target)
+ /// Indicates whether a kernel representation of the code should be generated.
+ ///
+ /// When `false`, an analyzer AST is generated, and type inference is copied
+ /// over to it, but the result is not converted to a kernel representation.
+ ///
+ /// TODO(paulberry): remove this once "kompile" functionality is no longer
+ /// needed.
+ final bool generateKernel;
+
+ /// Indicates whether a resolved AST should be generated.
+ ///
+ /// When `false`, an analyzer AST is generated, but none of the types or
+ /// elements pointed to by the AST are guaranteed to be correct.
+ ///
+ /// This is needed in order to support the old "kompile" use case, since the
+ /// tests of that functionality were based on the behavior prior to
+ /// integrating resolution and type inference with analyzer.
+ ///
+ /// TODO(paulberry): remove this once "kompile" functionality is no longer
+ /// needed.
+ final bool doResolution;
+
+ AnalyzerLoader(
+ TargetImplementation target, this.generateKernel, this.doResolution)
: super(PhysicalFileSystem.instance, target);
@override
@@ -43,7 +66,8 @@ class AnalyzerLoader<L> extends SourceLoader<L> {
@override
AnalyzerDietListener createDietListener(LibraryBuilder library) {
- return new AnalyzerDietListener(library, elementStore);
+ return new AnalyzerDietListener(library, elementStore, hierarchy, coreTypes,
+ typeInferenceEngine, generateKernel, doResolution);
}
@override

Powered by Google App Engine
This is Rietveld 408576698