Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: pkg/compiler/lib/src/kernel/env.dart

Issue 2981673002: Register created closure class with the world. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/env.dart
diff --git a/pkg/compiler/lib/src/kernel/env.dart b/pkg/compiler/lib/src/kernel/env.dart
index e47a85dae24f94b5223312615b4f6c95eb488b0a..2c31f77596a72cd20eaa76689ca41c6a5fa87658 100644
--- a/pkg/compiler/lib/src/kernel/env.dart
+++ b/pkg/compiler/lib/src/kernel/env.dart
@@ -161,6 +161,15 @@ class ClassEnv {
: isUnnamedMixinApplication =
cls.name.contains('+') || cls.name.contains('&');
+ // TODO(efortuna): This is gross because even though the closure class *has*
Siggi Cherem (dart-lang) 2017/07/12 21:25:04 Yeah -- how deep does the dependency on this goes?
Emily Fortuna 2017/07/12 22:02:18 Gooooood question. Johnni, does this mean we need
+ // members, we're not populating this because they aren't ir.Member types. :-(
+ ClassEnv.closureClass()
+ : cls = null,
+ isUnnamedMixinApplication = false,
+ _constructorMap = const <String, ir.Member>{},
+ _memberMap = const <String, ir.Member>{},
+ _setterMap = const <String, ir.Member>{};
+
/// Copied from 'package:kernel/transformations/mixin_full_resolution.dart'.
ir.Constructor _buildForwardingConstructor(
CloneVisitor cloner, ir.Constructor superclassConstructor) {

Powered by Google App Engine
This is Rietveld 408576698