Register created closure class with the world.

Register created closure class with the world.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e0ad5d0c0a59813d787b13d01b0178a422aff256

[Emily Fortuna, 2017-07-12 20:23:40]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-07-12 20:24:06]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Emily Fortuna, 2017-07-12 20:31:26]

Patchset #2 (id:40001) has been deleted

[Emily Fortuna, 2017-07-12 20:31:34]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-12 21:25:04]

lgtm

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:668:
closureData.isMixinApplication = false;
nit: let's use cascades :)

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/env.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/env.dart:164: // TODO(efortuna): This is gross
because even though the closure class *has*
Yeah -- how deep does the dependency on this goes? I mean, we will need to have
support in the ssa builder to understand that there are synthetic and
nonsynthetic members and not lookup the IR node for those?

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:379: /// closure class represents a closure that
is an instance member in a class.
not sure I understand the concept of a "closure instance member" do you mean
that it is a closure that appears within an instance member, and thus has access
to `this`?

If so, maybe rename the argument to "fromInstanceMember" and slighly rephrase
the comment?

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:1310: void registerClosureClass(ClassElement
cls, bool not_used) {
nit: a common convention is to use "_" for unused args

[Emily Fortuna, 2017-07-12 22:02:18]

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:668:
closureData.isMixinApplication = false;
On 2017/07/12 21:25:03, Siggi Cherem (dart-lang) wrote:
> nit: let's use cascades :)

That was my plan before, but I must have had a syntax error because it wasn't
liking it. got it now, though.

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/env.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/env.dart:164: // TODO(efortuna): This is gross
because even though the closure class *has*
On 2017/07/12 21:25:04, Siggi Cherem (dart-lang) wrote:
> Yeah -- how deep does the dependency on this goes? I mean, we will need to
have
> support in the ssa builder to understand that there are synthetic and
> nonsynthetic members and not lookup the IR node for those?
> 

Gooooood question. Johnni, does this mean we need to use Entities in more of
these maps rather than ir nodes?

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:379: /// closure class represents a closure that
is an instance member in a class.
On 2017/07/12 21:25:04, Siggi Cherem (dart-lang) wrote:
> not sure I understand the concept of a "closure instance member" do you mean
> that it is a closure that appears within an instance member, and thus has
access
> to `this`?
> 
> If so, maybe rename the argument to "fromInstanceMember" and slighly rephrase
> the comment?

yes, that's what I meant, and that is phrased much more sensically. Fixed!

https://codereview.chromium.org/2981673002/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:1310: void registerClosureClass(ClassElement
cls, bool not_used) {
On 2017/07/12 21:25:04, Siggi Cherem (dart-lang) wrote:
> nit: a common convention is to use "_" for unused args

done.

[Emily Fortuna, 2017-07-12 22:06:44]

Description was changed from

==========
Register created closure class with the world.

BUG=
==========

to

==========
Register created closure class with the world.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e0ad5d0c0a59813d787b13d01b0178a422aff256
==========

[Emily Fortuna, 2017-07-12 22:06:45]

Committed patchset #2 (id:80001) manually as
e0ad5d0c0a59813d787b13d01b0178a422aff256 (presubmit successful).