Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2981663002: Remove uses of internal API in closures_initializers suite. (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, ahe, Dmitry Stefantsov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove uses of internal API in closures_initializers suite. I had removed the uses in other suites, but this suite got added while my CL was being reviewed. I didn't notice this new case until today. R=paulberry@google.com CC=ahe@google.com,dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/03bc29f24cbe600526f9e4f673aa81f88c1e8265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -75 lines) Patch
M pkg/kernel/test/closures_initializers/suite.dart View 4 chunks +13 lines, -75 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-12 19:48:35 UTC) #1
Paul Berry
lgtm
3 years, 5 months ago (2017-07-12 20:34:26 UTC) #2
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-12 20:46:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03bc29f24cbe600526f9e4f673aa81f88c1e8265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698