Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2981653002: Rename most "debug" methods in TypeInferenceListener classes to "generic". (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename most "debug" methods in TypeInferenceListener classes to "generic". In a future CL I'm going to start taking advantage of the fact that these methods provide a fallback behavior when the listener doesn't override a more specific method, so to avoid confusion I'm renaming the methods to reflect that use case. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/285a18dd2339dc03449663c81e79b667ec3f7113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -122 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 3 chunks +125 lines, -122 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-07-12 18:07:37 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-12 18:13:08 UTC) #3
Paul Berry
3 years, 5 months ago (2017-07-12 19:29:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
285a18dd2339dc03449663c81e79b667ec3f7113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698