Introduce TypedefEntity

Introduce TypedefEntity

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/cb6bef3cb4f251538f3643d1237a9ebdac936fd8

[Johnni Winther, 2017-07-12 13:18:08]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-12 18:11:14]

lgtm

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1325: /// Returns the unaliased type
of [type].
we might want to define what "unaliased" type means here, or refer to where the
definition is.

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1338: /// Returns the alias of a
[typedef], that is, the function type it is an
nit, how about:

/// Returns the function type that is an alias of a [typedef].

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1340: FunctionType
getTypedefAlias(TypedefEntity typedef);
other name ideas:
 - getFunctionTypeOf
 - functionTypeOf
 - functionTypeOfTypedef
 - functionTypeAliasOf

[Johnni Winther, 2017-07-13 09:14:11]

Description was changed from

==========
Introduce TypedefEntity
==========

to

==========
Introduce TypedefEntity

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cb6bef3cb4f251538f3643d1237a9ebdac936fd8
==========

[Johnni Winther, 2017-07-13 09:14:12]

Committed patchset #2 (id:20001) manually as
cb6bef3cb4f251538f3643d1237a9ebdac936fd8 (presubmit successful).

[Johnni Winther, 2017-07-13 09:19:18]

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1325: /// Returns the unaliased type
of [type].
On 2017/07/12 18:11:14, Siggi Cherem (dart-lang) wrote:
> we might want to define what "unaliased" type means here, or refer to where
the
> definition is.

Done.

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1338: /// Returns the alias of a
[typedef], that is, the function type it is an
On 2017/07/12 18:11:13, Siggi Cherem (dart-lang) wrote:
> nit, how about:
> 
> /// Returns the function type that is an alias of a [typedef].

Done.

https://codereview.chromium.org/2981633002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1340: FunctionType
getTypedefAlias(TypedefEntity typedef);
On 2017/07/12 18:11:14, Siggi Cherem (dart-lang) wrote:
> other name ideas:
>  - getFunctionTypeOf
>  - functionTypeOf
>  - functionTypeOfTypedef
>  - functionTypeAliasOf

Renamed to [getFunctionTypeOfTypedef].