sandbox/linux/services/linux_syscalls.h - Issue 298163008: Non-SFI NaCl: Allow CLOCK_SYSTEM_TRACE on Chrome OS

Side by Side Diff: sandbox/linux/services/linux_syscalls.h

Issue 298163008: Non-SFI NaCl: Allow CLOCK_SYSTEM_TRACE on Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This header will be kept up to date so that we can compile system-call	5 // This header will be kept up to date so that we can compile system-call

6 // policies even when system headers are old.	6 // policies even when system headers are old.

7 // System call numbers are accessible through __NR_syscall_name.	7 // System call numbers are accessible through __NR_syscall_name.

8	8

9 #ifndef SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_	9 #ifndef SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_

10 #define SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_	10 #define SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_

11	11

12 #if defined(__x86_64__)	12 #if defined(__x86_64__)

13 #include "sandbox/linux/services/x86_64_linux_syscalls.h"	13 #include "sandbox/linux/services/x86_64_linux_syscalls.h"

14 #endif	14 #endif

15	15

16 #if defined(__i386__)	16 #if defined(__i386__)

17 #include "sandbox/linux/services/x86_32_linux_syscalls.h"	17 #include "sandbox/linux/services/x86_32_linux_syscalls.h"

18 #endif	18 #endif

19	19

20 #if defined(__arm__) && defined(__ARM_EABI__)	20 #if defined(__arm__) && defined(__ARM_EABI__)

21 #include "sandbox/linux/services/arm_linux_syscalls.h"	21 #include "sandbox/linux/services/arm_linux_syscalls.h"

22 #endif	22 #endif

23	23

	24 // A Chrome OS specific clock ID for clock_getres, clock_gettime, and

	25 // clock_settime. See base/time/time_posix.cc for detail.

	26 #define CLOCK_SYSTEM_TRACE 11
	hamaji 2014/05/28 07:36:46 Not sure this is the appropriate location for this Not sure this is the appropriate location for this constant. I put this here as Julien said we might want to do the same check for clock_gettime even from the base policy. Mark Seaborn 2014/05/28 15:24:03 Would it make sense to change base/time/time_posix Show quoted text On 2014/05/28 07:36:46, hamaji wrote: > Not sure this is the appropriate location for this constant. I put this here as > Julien said we might want to do the same check for clock_gettime even from the > base policy. Would it make sense to change base/time/time_posix.cc to share a common definition of this constant? Where can I learn what CLOCK_SYSTEM_TRACE does? time_posix.cc doesn't have any pointers. git annotate takes me to https://code.google.com/p/chromium/issues/detail?id=128650, which is not particularly informative. I did find this: http://code.google.com/p/chromium/issues/detail?id=324025 "ChromeOS 3.10 tracing CLOCK_SYSTEM_TRACE conflicts with CLOCK_TAI" "The version of the CLOCK_SCHED_TRACE patch in chromeos-3.10 has CLOCK_SYSTEM_TRACE defined at 12 instead of 11..." -- This suggests that having a single #define would be important! hamaji 2014/05/28 16:21:47 Sounds like a good idea. Done. Show quoted text On 2014/05/28 15:24:03, Mark Seaborn wrote: > On 2014/05/28 07:36:46, hamaji wrote: > > Not sure this is the appropriate location for this constant. I put this here > as > > Julien said we might want to do the same check for clock_gettime even from the > > base policy. > > Would it make sense to change base/time/time_posix.cc to share a common > definition of this constant? Sounds like a good idea. Done. Show quoted text > > Where can I learn what CLOCK_SYSTEM_TRACE does? time_posix.cc doesn't have any > pointers. git annotate takes me to > https://code.google.com/p/chromium/issues/detail?id=128650, which is not > particularly informative. I have added sleffler as a reviewer. Though it seems he is not working for Chromium anymore, I hope he will give us a pointer. Show quoted text > > I did find this: > http://code.google.com/p/chromium/issues/detail?id=324025 > "ChromeOS 3.10 tracing CLOCK_SYSTEM_TRACE conflicts with CLOCK_TAI" > > "The version of the CLOCK_SCHED_TRACE patch in chromeos-3.10 has > CLOCK_SYSTEM_TRACE defined at 12 instead of 11..." > > -- This suggests that having a single #define would be important!
	27

24 #endif // SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_	28 #endif // SANDBOX_LINUX_SERVICES_LINUX_SYSCALLS_H_

25

OLD	NEW

« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc ('k') | no next file » | no next file with comments »