Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2981553002: AnalysisOptionsProvider.getOptionsFile() should return only existing files. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AnalysisOptionsProvider.getOptionsFile() should return only existing files. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5cd77dda37ac0c6b965a872e72f8373cee0c01d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-11 20:36:03 UTC) #1
jwren
On 2017/07/11 20:36:03, scheglov wrote: LGTM
3 years, 5 months ago (2017-07-11 20:37:19 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 5cd77dda37ac0c6b965a872e72f8373cee0c01d6 (presubmit successful).
3 years, 5 months ago (2017-07-11 20:38:14 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-19 17:01:57 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698