Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4434)

Unified Diff: chrome/browser/resources/md_bookmarks/dialog_focus_manager.js

Issue 2981503002: [MD Bookmarks] Refactor focus ring hiding. (Closed)
Patch Set: rebase, address_comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
diff --git a/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js b/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
index 5b3879d72a2cd6bd36981149bd1be1dca4831066..ac5d84e9e41f8a39292094c146376dc7bdb2c14f 100644
--- a/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
+++ b/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
@@ -13,9 +13,6 @@ cr.define('bookmarks', function() {
/** @private {HTMLElement} */
this.previousFocusElement_ = null;
- /** @private {boolean} */
- this.previousMouseFocus_ = false;
-
/** @private {Set<HTMLDialogElement>} */
this.dialogs_ = new Set();
}
@@ -50,8 +47,6 @@ cr.define('bookmarks', function() {
/** @private */
updatePreviousFocus_: function() {
this.previousFocusElement_ = this.getFocusedElement_();
- this.previousMouseFocus_ = bookmarks.MouseFocusBehavior.isMouseFocused(
- this.previousFocusElement_);
},
/**
@@ -80,13 +75,9 @@ cr.define('bookmarks', function() {
assert(this.dialogs_.delete(dialog));
// Focus the originally focused element if there are no more dialogs.
- if (!this.dialogs_.size) {
+ if (!this.dialogs_.size)
this.previousFocusElement_.focus();
- if (this.previousMouseFocus_) {
- bookmarks.MouseFocusBehavior.addMouseFocusClass(
- this.previousFocusElement_);
- }
- }
+
dialog.removeEventListener('close', closeListener);
}.bind(this);

Powered by Google App Engine
This is Rietveld 408576698