Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2981483002: Use more single quotes in js_runtime (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use more single quotes in js_runtime This makes searching easier. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3e9dba56870cf1f3ef6614ef3f97844e5a1c4fa3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -160 lines) Patch
M sdk/lib/_internal/js_runtime/lib/async_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/constant_map.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 19 chunks +32 lines, -32 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 21 chunks +25 lines, -25 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_mirrors.dart View 14 chunks +19 lines, -19 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_number.dart View 12 chunks +24 lines, -24 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/math_patch.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_typed_data.dart View 21 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 5 months ago (2017-07-11 02:45:29 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-11 02:46:57 UTC) #3
sra1
3 years, 5 months ago (2017-07-11 17:47:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e9dba56870cf1f3ef6614ef3f97844e5a1c4fa3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698