Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 298143004: Minor cleanups & trivial refactoring related to Ast. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Minor cleanups & trivial refactoring related to Ast. 1) Literal::IsNull, IsTrue and IsFalse were dead code, and not needed. 2) No need to use the node type constants outside the Ast; there is IsSomeNodeType(). 3) AsSomeNodeType() != NULL -> IsSomeNodeType(). R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21621

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -30 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/ast.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
rossberg, ptal. Just some minor cleanups which I carved out of the symbol table CL.
6 years, 6 months ago (2014-05-30 16:12:57 UTC) #1
rossberg
lgtm
6 years, 6 months ago (2014-06-02 12:57:58 UTC) #2
marja
6 years, 6 months ago (2014-06-03 07:41:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698