Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap

pkg/compiler/lib/src/closure.dart

Index: pkg/compiler/lib/src/closure.dart
diff --git a/pkg/compiler/lib/src/closure.dart b/pkg/compiler/lib/src/closure.dart
index 637237cab18224ce7e258ac0df3acaea29e41b7b..5b43c620643ced8991ec76a4be9b896183b556e6 100644
--- a/pkg/compiler/lib/src/closure.dart
+++ b/pkg/compiler/lib/src/closure.dart
@@ -482,9 +482,7 @@ class ClosureClassElement extends ClassElementX {
             // classes (since the emitter sorts classes by their id).
             compiler.idGenerator.getNextFreeId(),
             STATE_DONE) {
-    ClassElement superclass = methodElement.isInstanceMember
-        ? compiler.resolution.commonElements.boundClosureClass

[Emily Fortuna, 2017/07/21 22:21:43]

This was the behavior in the old code. Why is it no longer necessary?

[Johnni Winther, 2017/07/28 12:08:19]

This is what happens when the types are not precise enough: Originally the type
of [methodElement] was `FunctionElement` which includes both `MethodElement`
(which can be an instance member) and `LocalFunctionElement` (which can't). When
I improved the type precision of `closure.dart` to always use
[LocalFunctionElement] I didn't notice this line. We have _never_ created a
closure class for a tear-off but the types indicated that we did.

-        : compiler.resolution.commonElements.closureClass;
+    ClassElement superclass = compiler.resolution.commonElements.closureClass;
     superclass.ensureResolved(compiler.resolution);
     supertype = superclass.thisType;
     interfaces = const Link<ResolutionDartType>();
@@ -1379,7 +1377,7 @@ class ClosureTranslator extends Visitor {
     ClosureClassElement globalizedElement =
         new ClosureClassElement(node, closureName, compiler, element);
     // Extend [globalizedElement] as an instantiated class in the closed world.
-    closedWorldRefiner.registerClosureClass(globalizedElement, false);
+    closedWorldRefiner.registerClosureClass(globalizedElement);
     MethodElement callElement = new SynthesizedCallMethodElementX(
         Identifiers.call, element, globalizedElement, node, elements);
     backend.mirrorsDataBuilder.maybeMarkClosureAsNeededForReflection(