Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: chrome/browser/extensions/webstore_standalone_installer.h

Issue 298133007: Fixed leaks of WebstoreStandaloneInstallers in some code paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@install_base
Patch Set: Fix inline installer test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_standalone_installer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 virtual void InstallUIAbort(bool user_initiated) OVERRIDE; 179 virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
180 180
181 // WebstoreInstaller::Delegate interface implementation. 181 // WebstoreInstaller::Delegate interface implementation.
182 virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE; 182 virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
183 virtual void OnExtensionInstallFailure( 183 virtual void OnExtensionInstallFailure(
184 const std::string& id, 184 const std::string& id,
185 const std::string& error, 185 const std::string& error,
186 WebstoreInstaller::FailureReason reason) OVERRIDE; 186 WebstoreInstaller::FailureReason reason) OVERRIDE;
187 187
188 void ShowInstallUI(); 188 void ShowInstallUI();
189 void OnWebStoreDataFetcherDone();
189 190
190 // Input configuration. 191 // Input configuration.
191 std::string id_; 192 std::string id_;
192 Callback callback_; 193 Callback callback_;
193 Profile* profile_; 194 Profile* profile_;
194 WebstoreInstaller::InstallSource install_source_; 195 WebstoreInstaller::InstallSource install_source_;
195 196
196 // Installation dialog and its underlying prompt. 197 // Installation dialog and its underlying prompt.
197 scoped_ptr<ExtensionInstallPrompt> install_ui_; 198 scoped_ptr<ExtensionInstallPrompt> install_ui_;
198 scoped_ptr<ExtensionInstallPrompt::Prompt> install_prompt_; 199 scoped_ptr<ExtensionInstallPrompt::Prompt> install_prompt_;
(...skipping 15 matching lines...) Expand all
214 // Created by ShowInstallUI() when a prompt is shown (if 215 // Created by ShowInstallUI() when a prompt is shown (if
215 // the implementor returns a non-NULL in CreateInstallPrompt()). 216 // the implementor returns a non-NULL in CreateInstallPrompt()).
216 scoped_refptr<Extension> localized_extension_for_display_; 217 scoped_refptr<Extension> localized_extension_for_display_;
217 218
218 DISALLOW_IMPLICIT_CONSTRUCTORS(WebstoreStandaloneInstaller); 219 DISALLOW_IMPLICIT_CONSTRUCTORS(WebstoreStandaloneInstaller);
219 }; 220 };
220 221
221 } // namespace extensions 222 } // namespace extensions
222 223
223 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_ 224 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_STANDALONE_INSTALLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_standalone_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698