Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 298133005: Remove cpp hack to avoid link failures on Windows (Closed)

Created:
6 years, 7 months ago by rossberg
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Remove cpp hack to avoid link failures on Windows TBR=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M src/types.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-types.cc View 4 chunks +29 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 7 months ago (2014-05-27 14:26:15 UTC) #1
rossberg
Committed patchset #1 manually as r21532 (tree was closed).
6 years, 7 months ago (2014-05-27 14:26:40 UTC) #2
Yang
6 years, 7 months ago (2014-05-27 14:27:33 UTC) #3
Message was sent while issue was closed.
On 2014/05/27 14:26:40, rossberg wrote:
> Committed patchset #1 manually as r21532 (tree was closed).

lgtm.

Powered by Google App Engine
This is Rietveld 408576698