Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: Source/core/dom/Touch.h

Issue 298133003: Expose fractional TouchEvent coordinates (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make layout test output stable across platforms Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.idl ('k') | Source/core/dom/Touch.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Touch.h
diff --git a/Source/core/dom/Touch.h b/Source/core/dom/Touch.h
index 2b86fd0ff027ac0ab12d5157faacf48ae67c4aca..c4896bbd4f29ad5f48feccb238ae2277e26ef9b7 100644
--- a/Source/core/dom/Touch.h
+++ b/Source/core/dom/Touch.h
@@ -28,6 +28,8 @@
#include "bindings/v8/ScriptWrappable.h"
#include "core/events/EventTarget.h"
+#include "platform/geometry/FloatPoint.h"
+#include "platform/geometry/FloatSize.h"
#include "platform/geometry/LayoutPoint.h"
#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
@@ -41,51 +43,58 @@ class LocalFrame;
class Touch FINAL : public RefCountedWillBeGarbageCollectedFinalized<Touch>, public ScriptWrappable {
public:
static PassRefPtrWillBeRawPtr<Touch> create(LocalFrame* frame, EventTarget* target,
- unsigned identifier, int screenX, int screenY, int pageX, int pageY,
- int radiusX, int radiusY, float rotationAngle, float force)
+ unsigned identifier, const FloatPoint& screenPos, const FloatPoint& pagePos,
+ const FloatSize& radius, float rotationAngle, float force)
{
- return adoptRefWillBeNoop(new Touch(frame, target, identifier, screenX,
- screenY, pageX, pageY, radiusX, radiusY, rotationAngle, force));
+ return adoptRefWillBeNoop(
+ new Touch(frame, target, identifier, screenPos, pagePos, radius, rotationAngle, force));
}
+ // DOM Touch implementation
EventTarget* target() const { return m_target.get(); }
unsigned identifier() const { return m_identifier; }
- int clientX() const { return m_clientX; }
- int clientY() const { return m_clientY; }
- int screenX() const { return m_screenX; }
- int screenY() const { return m_screenY; }
- int pageX() const { return m_pageX; }
- int pageY() const { return m_pageY; }
- int webkitRadiusX() const { return m_radiusX; }
- int webkitRadiusY() const { return m_radiusY; }
+ double clientX() const { return m_clientPos.x(); }
+ double clientY() const { return m_clientPos.y(); }
+ double screenX() const { return m_screenPos.x(); }
+ double screenY() const { return m_screenPos.y(); }
+ double pageX() const { return m_pagePos.x(); }
+ double pageY() const { return m_pagePos.y(); }
+ double webkitRadiusX() const { return m_radius.width(); }
+ double webkitRadiusY() const { return m_radius.height(); }
float webkitRotationAngle() const { return m_rotationAngle; }
float webkitForce() const { return m_force; }
+
+ // Blink-internal methods
const LayoutPoint& absoluteLocation() const { return m_absoluteLocation; }
+ const FloatPoint& screenLocation() const { return m_screenPos; }
PassRefPtrWillBeRawPtr<Touch> cloneWithNewTarget(EventTarget*) const;
void trace(Visitor*);
private:
Touch(LocalFrame* frame, EventTarget* target, unsigned identifier,
- int screenX, int screenY, int pageX, int pageY,
- int radiusX, int radiusY, float rotationAngle, float force);
+ const FloatPoint& screenPos, const FloatPoint& pagePos,
+ const FloatSize& radius, float rotationAngle, float force);
- Touch(EventTarget*, unsigned identifier, int clientX, int clientY,
- int screenX, int screenY, int pageX, int pageY,
- int radiusX, int radiusY, float rotationAngle, float force, LayoutPoint absoluteLocation);
+ Touch(EventTarget*, unsigned identifier, const FloatPoint& clientPos,
+ const FloatPoint& screenPos, const FloatPoint& pagePos,
+ const FloatSize& radius, float rotationAngle, float force, LayoutPoint absoluteLocation);
RefPtrWillBeMember<EventTarget> m_target;
unsigned m_identifier;
- int m_clientX;
- int m_clientY;
- int m_screenX;
- int m_screenY;
- int m_pageX;
- int m_pageY;
- int m_radiusX;
- int m_radiusY;
+ // Position relative to the viewport in CSS px.
+ FloatPoint m_clientPos;
+ // Position relative to the screen in DIPs.
+ FloatPoint m_screenPos;
+ // Position relative to the page in CSS px.
+ FloatPoint m_pagePos;
+ // Radius in CSS px.
+ FloatSize m_radius;
float m_rotationAngle;
float m_force;
+ // FIXME(rbyers): Shouldn't we be able to migrate callers to relying on screenPos, pagePos
+ // or clientPos? absoluteLocation appears to be the same as pagePos but without browser
+ // scale applied.
LayoutPoint m_absoluteLocation;
};
« no previous file with comments | « Source/core/dom/Document.idl ('k') | Source/core/dom/Touch.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698