content/browser/frame_host/render_frame_host_manager.cc - Issue 298133002: Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 298133002: Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests + review suggestion Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 29e6052fabb48307653260efd6bc6c248f984c2c..1800d28520d3cdb05a28549e50eeee3e08ba18c9 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -1018,7 +1018,11 @@ bool RenderFrameHostManager::InitRenderView(RenderViewHost* render_view_host,

// process unless it's swapped out.

RenderViewHostImpl* rvh_impl =

static_cast<RenderViewHostImpl*>(render_view_host);

- if (!rvh_impl->IsSwappedOut()) {

+ // In single-process mode, we are forced to create all render views in

+ // the same single process.

+ bool single_process =

+ RenderProcessHost::run_renderer_in_process();

+ if (!rvh_impl->IsSwappedOut() && !single_process) {

CHECK(!ChildProcessSecurityPolicyImpl::GetInstance()->HasWebUIBindings(

render_view_host->GetProcess()->GetID()));

}