Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as …

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigator.h"
@@ skipping 1074 matching lines @@
   // used yet. UpdateStateForNavigate() took the short cut path.
   EXPECT_FALSE(manager->pending_web_ui());
   EXPECT_TRUE(manager->web_ui());
 
   // Commit.
   manager->DidNavigateFrame(host);
   EXPECT_TRUE(
       host->render_view_host()->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI);
 }
 
+TEST_F(RenderFrameHostManagerTest,
+       CanNavigateBetweenNormalPagesAndWebUIInSingleProcess) {

[nasko, 2014/05/28 17:02:04]

This test doesn't seem to work as expected. The renderer doesn't get WebUI
bindings, as the code that grants them checks for the actual "--single-process"
flag :(.

+  const GURL kNormalUrl1("http://chromium.org");
+  const GURL kNormalUrl2("http://example.com");
+  const GURL kWebUIUrl("chrome://foo");
+
+  RenderProcessHost::SetRunRendererInProcess(true);
+  set_should_create_webui(true);
+
+  RenderFrameHostManager* manager =
+      static_cast<TestWebContents*>(
+        web_contents())->GetRenderManagerForTesting();

[nasko, 2014/05/28 17:02:04]

nit: wrong indent

+
+  NavigateAndCommit(kNormalUrl1);
+  EXPECT_EQ(kNormalUrl1,
+            manager->current_frame_host()->GetSiteInstance()->GetSiteURL());
+  EXPECT_FALSE(manager->web_ui());
+  NavigateAndCommit(kWebUIUrl);
+  EXPECT_EQ(kWebUIUrl,
+            manager->current_frame_host()->GetSiteInstance()->GetSiteURL());
+  EXPECT_TRUE(manager->web_ui());
+  NavigateAndCommit(kNormalUrl2);
+  EXPECT_EQ(kNormalUrl2,
+            manager->current_frame_host()->GetSiteInstance()->GetSiteURL());
+  EXPECT_FALSE(manager->web_ui());
+}
+
 // Tests that we can open a WebUI link in a new tab from a WebUI page and still
 // grant the correct bindings.  http://crbug.com/189101.
 TEST_F(RenderFrameHostManagerTest, WebUIInNewTab) {
   set_should_create_webui(true);
   SiteInstance* blank_instance = SiteInstance::Create(browser_context());
 
   // Create a blank tab.
   scoped_ptr<TestWebContents> web_contents1(
       TestWebContents::Create(browser_context(), blank_instance));
   RenderFrameHostManager* manager1 =
@@ skipping 733 matching lines @@
         pending_rfh->GetSiteInstance())->increment_active_view_count();
 
     main_test_rfh()->OnMessageReceived(
         FrameHostMsg_BeforeUnload_ACK(0, false, now, now));
     EXPECT_FALSE(contents()->cross_navigation_pending());
     EXPECT_FALSE(rvh_deleted_observer.deleted());
   }
 }
 
 }  // namespace content