[Fuchsia] Switch to cwriter tracing API.

[Fuchsia] Switch to cwriter tracing API.

The cwriter API allows us to directly pass timestamps and
programmatically assemble arguments.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/412283a76316edc159cb50858d9ac1e3227f1ac5

[zra, 2017-07-19 21:26:22]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2017-07-19 21:26:23]

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:14: #include "apps/tracing/lib/trace/cwriter.h"
Alphabetize includes

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:561: uint64_t time_scale = mx_ticks_per_second() /
kMicrosecondsPerSecond;
const

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:562: uint64_t start_time = LowTime() * time_scale;
const

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:563: uint64_t end_time = HighTime() * time_scale;
const

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:1002: #if defined(HOST_OS_FUCHSIA)
Since EmitFuchsiaEvent now does the right thing for kDuration events, I think
TimelineDurationScope no longer needs a special case for Fuchsia.

[konkers, 2017-07-19 21:52:32]

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:14: #include "apps/tracing/lib/trace/cwriter.h"
On 2017/07/19 21:26:23, zra wrote:
> Alphabetize includes

Done.

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:561: uint64_t time_scale = mx_ticks_per_second() /
kMicrosecondsPerSecond;
On 2017/07/19 21:26:23, zra wrote:
> const

Done.

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:562: uint64_t start_time = LowTime() * time_scale;
On 2017/07/19 21:26:23, zra wrote:
> const

Done.

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:563: uint64_t end_time = HighTime() * time_scale;
On 2017/07/19 21:26:23, zra wrote:
> const

Done.

https://codereview.chromium.org/2981323002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:1002: #if defined(HOST_OS_FUCHSIA)
On 2017/07/19 21:26:23, zra wrote:
> Since EmitFuchsiaEvent now does the right thing for kDuration events, I think
> TimelineDurationScope no longer needs a special case for Fuchsia.

Done.

[zra, 2017-07-19 21:58:01]

lgtm

[zra, 2017-07-19 22:04:40]

Description was changed from

==========
[Fuchsia] Switch to cwriter tracing API.

The cwriter API allows us to directly pass timestamps and
programmatically assemble arguments.

BUG=
==========

to

==========
[Fuchsia] Switch to cwriter tracing API.

The cwriter API allows us to directly pass timestamps and
programmatically assemble arguments.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/412283a76316edc159cb50858d9ac1e3227f1ac5
==========

[zra, 2017-07-19 22:04:42]

Committed patchset #5 (id:80001) manually as
412283a76316edc159cb50858d9ac1e3227f1ac5 (presubmit successful).