Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2981303002: Include default values for default field formal parameters into text dump. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include default values for default field formal parameters into text dump. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/94815c7bdb84aba04363e0e35024e5c811f23dcf

Patch Set 1 #

Patch Set 2 : Remove debug output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M pkg/analyzer/test/src/summary/element_text.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 9 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-19 19:10:24 UTC) #1
Paul Berry
lgtm
3 years, 5 months ago (2017-07-19 19:30:49 UTC) #2
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-19 19:31:05 UTC) #3
scheglov
3 years, 5 months ago (2017-07-19 19:42:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
94815c7bdb84aba04363e0e35024e5c811f23dcf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698