Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 2981283002: rename test methods and format (Closed)

Created:
3 years, 5 months ago by danrubel
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rename test methods and format * rename usingFasta --> usingFastaParser * add usingFastaScanner * apply dartfmt R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/3b2625ccdec4a6850956ad01ee661dda8e0eff83

Patch Set 1 #

Patch Set 2 : rebase and dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 5 months ago (2017-07-19 18:02:36 UTC) #2
Paul Berry
lgtm
3 years, 5 months ago (2017-07-19 18:03:29 UTC) #3
danrubel
3 years, 5 months ago (2017-07-20 13:51:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3b2625ccdec4a6850956ad01ee661dda8e0eff83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698