isolate: (refactor) extract blacklisting into common package

client/archiver/directory_test.go

Index: client/archiver/directory_test.go
diff --git a/client/archiver/directory_test.go b/client/archiver/directory_test.go
index b509dfa880115c925ee0172ab71f1e761f9740c7..f810df7d008ec9dfcfb5820eb6b718eb42043bd4 100644
--- a/client/archiver/directory_test.go
+++ b/client/archiver/directory_test.go
@@ -16,12 +16,10 @@ package archiver
 
 import (
 	"encoding/json"
-	"errors"
 	"io/ioutil"
 	"net/http/httptest"
 	"os"
 	"path/filepath"
-	"sync"
 	"testing"
 
 	"golang.org/x/net/context"
@@ -35,25 +33,6 @@ import (
 	. "github.com/smartystreets/goconvey/convey"
 )
 
-func TestWalkBadRegexp(t *testing.T) {

[mithro, 2017/07/19 04:48:40]

This test was removed because it is now covered by
filesystem_view_linux_test.go?

[mcgreevy, 2017/07/19 05:11:04]

Yes.

-	Convey(`A bad regexp should fail when walking a directory.`, t, func() {
-		ch := make(chan *walkItem)
-		var wg sync.WaitGroup
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
-			defer close(ch)
-			walk("inexistent", []string{"a["}, ch)
-		}()
-		item := <-ch
-		So(item, ShouldResemble, &walkItem{err: errors.New("bad blacklist pattern \"a[\"")})
-		item, ok := <-ch
-		So(item, ShouldBeNil)
-		So(ok, ShouldBeFalse)
-		wg.Wait()
-	})
-}
-
 func TestPushDirectory(t *testing.T) {
 	// Uploads a real directory. 2 times the same file.
 	t.Parallel()