Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: client/cmd/isolate/common.go

Issue 2981243002: isolate: (refactor) extract blacklisting into common package (Closed)
Patch Set: address review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « client/archiver/directory_test.go ('k') | client/internal/common/filesystem_view.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The LUCI Authors. 1 // Copyright 2015 The LUCI Authors.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 // TODO(tandrii): move ArchiveOptions from isolate pkg to here. 82 // TODO(tandrii): move ArchiveOptions from isolate pkg to here.
83 isolate.ArchiveOptions 83 isolate.ArchiveOptions
84 } 84 }
85 85
86 func (c *isolateFlags) Init(f *flag.FlagSet) { 86 func (c *isolateFlags) Init(f *flag.FlagSet) {
87 c.ArchiveOptions.Init() 87 c.ArchiveOptions.Init()
88 f.StringVar(&c.Isolate, "isolate", "", ".isolate file to load the depend ency data from") 88 f.StringVar(&c.Isolate, "isolate", "", ".isolate file to load the depend ency data from")
89 f.StringVar(&c.Isolate, "i", "", "Alias for --isolate") 89 f.StringVar(&c.Isolate, "i", "", "Alias for --isolate")
90 f.StringVar(&c.Isolated, "isolated", "", ".isolated file to generate or read") 90 f.StringVar(&c.Isolated, "isolated", "", ".isolated file to generate or read")
91 f.StringVar(&c.Isolated, "s", "", "Alias for --isolated") 91 f.StringVar(&c.Isolated, "s", "", "Alias for --isolated")
92 » f.Var(&c.Blacklist, "blacklist", "List of regexp to use as blacklist fil ter when uploading directories") 92 » f.Var(&c.Blacklist, "blacklist", "List of globs to use as blacklist filt er when uploading directories")
93 f.Var(&c.ConfigVariables, "config-variable", "Config variables are used to determine which conditions should be matched when loading a .isolate file, de fault: [].") 93 f.Var(&c.ConfigVariables, "config-variable", "Config variables are used to determine which conditions should be matched when loading a .isolate file, de fault: [].")
94 f.Var(&c.PathVariables, "path-variable", "Path variables are used to rep lace file paths when loading a .isolate file, default: {}") 94 f.Var(&c.PathVariables, "path-variable", "Path variables are used to rep lace file paths when loading a .isolate file, default: {}")
95 f.Var(&c.ExtraVariables, "extra-variable", "Extraneous variables are rep laced on the command entry and on paths in the .isolate file but are not conside red relative paths.") 95 f.Var(&c.ExtraVariables, "extra-variable", "Extraneous variables are rep laced on the command entry and on paths in the .isolate file but are not conside red relative paths.")
96 } 96 }
97 97
98 // RequiredIsolateFlags specifies which flags are required on the command line 98 // RequiredIsolateFlags specifies which flags are required on the command line
99 // being parsed. 99 // being parsed.
100 type RequiredIsolateFlags uint 100 type RequiredIsolateFlags uint
101 101
102 const ( 102 const (
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 } 141 }
142 142
143 // loggingFlags configures eventlog logging. 143 // loggingFlags configures eventlog logging.
144 type loggingFlags struct { 144 type loggingFlags struct {
145 EventlogEndpoint string 145 EventlogEndpoint string
146 } 146 }
147 147
148 func (lf *loggingFlags) Init(f *flag.FlagSet) { 148 func (lf *loggingFlags) Init(f *flag.FlagSet) {
149 f.StringVar(&lf.EventlogEndpoint, "eventlog-endpoint", "", `The URL dest ination for eventlogs. The special values "prod" or "test" may be used to target the standard prod or test urls repspectively. An empty string disables eventlog ging.`) 149 f.StringVar(&lf.EventlogEndpoint, "eventlog-endpoint", "", `The URL dest ination for eventlogs. The special values "prod" or "test" may be used to target the standard prod or test urls repspectively. An empty string disables eventlog ging.`)
150 } 150 }
OLDNEW
« no previous file with comments | « client/archiver/directory_test.go ('k') | client/internal/common/filesystem_view.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698