isolate: (refactor) extract blacklisting into common package

client/archiver/directory_test.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 package archiver
 
 import (
         "encoding/json"
-        "errors"
         "io/ioutil"
         "net/http/httptest"
         "os"
         "path/filepath"
-        "sync"
         "testing"
 
         "golang.org/x/net/context"
 
         "github.com/luci/luci-go/client/internal/common"
         "github.com/luci/luci-go/common/data/text/units"
         "github.com/luci/luci-go/common/isolated"
         "github.com/luci/luci-go/common/isolatedclient"
         "github.com/luci/luci-go/common/isolatedclient/isolatedfake"
 
         . "github.com/smartystreets/goconvey/convey"
 )
 
-func TestWalkBadRegexp(t *testing.T) {
-        Convey(`A bad regexp should fail when walking a directory.`, t, func() {
-                ch := make(chan *walkItem)
-                var wg sync.WaitGroup
-                wg.Add(1)
-                go func() {
-                        defer wg.Done()
-                        defer close(ch)
-                        walk("inexistent", []string{"a["}, ch)
-                }()
-                item := <-ch
-                So(item, ShouldResemble, &walkItem{err: errors.New("bad blacklist pattern \"a[\"")})
-                item, ok := <-ch
-                So(item, ShouldBeNil)
-                So(ok, ShouldBeFalse)
-                wg.Wait()
-        })
-}
-
 func TestPushDirectory(t *testing.T) {
         // Uploads a real directory. 2 times the same file.
         t.Parallel()
         emptyContext := context.Background()
 
         Convey(`Pushing a real directory should upload the directory.`, t, func() {
                 server := isolatedfake.New()
                 ts := httptest.NewServer(server)
                 defer ts.Close()
                 a := New(emptyContext, isolatedclient.New(nil, nil, ts.URL, isolatedclient.DefaultNamespace, nil, nil), nil)
@@ skipping 57 matching lines @@
                 stats := a.Stats()
                 So(stats.TotalHits(), ShouldResemble, 0)
                 // There're 3 cache misses even if the same content is looked up twice.
                 So(stats.TotalMisses(), ShouldResemble, 3)
                 So(stats.TotalBytesHits(), ShouldResemble, units.Size(0))
                 So(stats.TotalBytesPushed(), ShouldResemble, units.Size(3+3+len(isolatedEncoded)))
 
                 So(server.Error(), ShouldBeNil)
         })
 }