Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 2981223002: Remove Dartium support from test.dart. (Closed)
Patch Set: Remove "dartium" from status files. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/docs/docs.status ('k') | tools/testing/dart/browser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 3700a29aeb6814ea3252307f52b91ce5a7ff01f4..94890e3563d699bda7e22f68bc5018275b108bd6 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -81,9 +81,6 @@ abstract class Browser {
case Runtime.chrome:
browser = new Chrome();
break;
- case Runtime.dartium:
- browser = new Dartium(checkedMode);
- break;
case Runtime.safari:
browser = new Safari();
break;
@@ -110,8 +107,7 @@ abstract class Browser {
'chrome',
'ie9',
'ie10',
- 'ie11',
- 'dartium'
+ 'ie11'
];
static bool requiresFocus(String browserName) {
@@ -584,26 +580,6 @@ class SafariMobileSimulator extends Safari {
String toString() => "SafariMobileSimulator";
}
-class Dartium extends Chrome {
- final bool checkedMode;
-
- Dartium(this.checkedMode);
-
- Map<String, String> _getEnvironment() {
- var environment = new Map<String, String>.from(Platform.environment);
- // By setting this environment variable, dartium will forward "print()"
- // calls in dart to the top-level javascript function "dartPrint()" if
- // available.
- environment['DART_FORWARDING_PRINT'] = '1';
- if (checkedMode) {
- environment['DART_FLAGS'] = '--checked';
- }
- return environment;
- }
-
- String toString() => "Dartium";
-}
-
class IE extends Browser {
Future<String> getVersion() {
var args = [
@@ -670,9 +646,6 @@ final contentShellOnAndroidConfig = new AndroidBrowserConfig(
'.ContentShellActivity',
'android.intent.action.VIEW');
-final dartiumOnAndroidConfig = new AndroidBrowserConfig('DartiumOnAndroid',
- 'com.google.android.apps.chrome', '.Main', 'android.intent.action.VIEW');
-
class AndroidBrowser extends Browser {
final bool checkedMode;
AdbDevice _adbDevice;
« no previous file with comments | « tools/dom/docs/docs.status ('k') | tools/testing/dart/browser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698