Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 2981223002: Remove Dartium support from test.dart. (Closed)
Patch Set: Remove "dartium" from status files. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1337 } 1337 }
1338 1338
1339 decodeOutput(); 1339 decodeOutput();
1340 if (stdout.any(containsOutOfMemoryMessage) || 1340 if (stdout.any(containsOutOfMemoryMessage) ||
1341 stderr.any(containsOutOfMemoryMessage)) { 1341 stderr.any(containsOutOfMemoryMessage)) {
1342 return true; 1342 return true;
1343 } 1343 }
1344 } 1344 }
1345 } 1345 }
1346 1346
1347 // We currently rerun dartium tests, see issue 14074.
1348 if (command is BrowserTestCommand &&
1349 command.retry &&
1350 command.browser == Runtime.dartium) {
1351 return true;
1352 }
1353
1354 // As long as we use a legacy version of our custom content_shell (which 1347 // As long as we use a legacy version of our custom content_shell (which
1355 // became quite flaky after chrome-50 roll) we'll re-run tests on it. 1348 // became quite flaky after chrome-50 roll) we'll re-run tests on it.
1356 // The plan is to use chrome's content_shell instead of our own. 1349 // The plan is to use chrome's content_shell instead of our own.
1357 // See http://dartbug.com/29655 . 1350 // See http://dartbug.com/29655 .
1358 if (command is ContentShellCommand) { 1351 if (command is ContentShellCommand) {
1359 return true; 1352 return true;
1360 } 1353 }
1361 1354
1362 if (io.Platform.operatingSystem == 'linux') { 1355 if (io.Platform.operatingSystem == 'linux') {
1363 decodeOutput(); 1356 decodeOutput();
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
1642 } 1635 }
1643 } 1636 }
1644 1637
1645 void eventAllTestsDone() { 1638 void eventAllTestsDone() {
1646 for (var listener in _eventListener) { 1639 for (var listener in _eventListener) {
1647 listener.allDone(); 1640 listener.allDone();
1648 } 1641 }
1649 _allDone(); 1642 _allDone();
1650 } 1643 }
1651 } 1644 }
OLDNEW
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698