Remove Dartium support from test.dart.

Remove Dartium support from test.dart.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/012774c78e086d650ad0731cd5de48a04afaf7d0

[Bob Nystrom, 2017-07-18 21:59:51]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-07-19 14:13:07]

LGTM, with comments addressed.

In browser_test.dart, in the HTML template, I don't think we need to add the
script
  <script type="text/javascript"
          src="/root_dart/pkg/browser/lib/dart.js"></script>
any more, because we have no scripts of type application/dart in the page any
more.

In http_server.dart, anything having to do with packages and serving packages
can be removed, since that was only needed by dartium.  The package_resolver
package can also be removed then.  Was that the only package: used by test.dart?

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/runtime_...
File tools/testing/dart/runtime_updater.dart (right):

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/runtime_...
tools/testing/dart/runtime_updater.dart:13: /// Runs "tools/get_archive.py" to
download and install Content Shell.
Check runtime against drt here, and return null (or future(Null)) if the runtime
isn't drt.  Or put the check in the code that calls this, and don't call if the
runtime isn't drt.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1057: _createWrapperFile(dartWrapperFilename,
filePath);
This should be dead code, and removed.  We don't support browser tests with
compiler == none.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1064: if (configuration.compiler !=
Compiler.none) {
This should always be true

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1070: content = getHtmlContents(fileName,
scriptType, scriptPath);
scriptType is always 'text/javascript'

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1099: break;
Remove this case.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1122: default:
Remove.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1126: if (configuration.compiler ==
Compiler.none) {
Remove.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1179: if (configuration.compiler ==
Compiler.none) {
Remove.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1203: void
_enqueueHtmlTest(HtmlTestInformation info, String testName,
Ignore this function, since we think we want to remove these (the _html.test
tests) anyway.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1311: String get scriptType {
This function can be replaced with 'text/javascript', and places using it can be
simplified.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1724: 
I think everything after this is dead code.  There is no dartc anymore.  No code
refers to these classes.

[Bob Nystrom, 2017-07-20 00:00:01]

Thanks!

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/runtime_...
File tools/testing/dart/runtime_updater.dart (right):

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/runtime_...
tools/testing/dart/runtime_updater.dart:13: /// Runs "tools/get_archive.py" to
download and install Content Shell.
On 2017/07/19 14:13:06, Bill Hesse wrote:
> Check runtime against drt here, and return null (or future(Null)) if the
runtime
> isn't drt.  Or put the check in the code that calls this, and don't call if
the
> runtime isn't drt.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1057: _createWrapperFile(dartWrapperFilename,
filePath);
On 2017/07/19 14:13:06, Bill Hesse wrote:
> This should be dead code, and removed.  We don't support browser tests with
> compiler == none.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1064: if (configuration.compiler !=
Compiler.none) {
On 2017/07/19 14:13:07, Bill Hesse wrote:
> This should always be true

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1070: content = getHtmlContents(fileName,
scriptType, scriptPath);
On 2017/07/19 14:13:06, Bill Hesse wrote:
> scriptType is always 'text/javascript'

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1099: break;
On 2017/07/19 14:13:07, Bill Hesse wrote:
> Remove this case.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1122: default:
On 2017/07/19 14:13:06, Bill Hesse wrote:
> Remove.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1126: if (configuration.compiler ==
Compiler.none) {
On 2017/07/19 14:13:07, Bill Hesse wrote:
> Remove.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1179: if (configuration.compiler ==
Compiler.none) {
On 2017/07/19 14:13:07, Bill Hesse wrote:
> Remove.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1203: void
_enqueueHtmlTest(HtmlTestInformation info, String testName,
On 2017/07/19 14:13:06, Bill Hesse wrote:
> Ignore this function, since we think we want to remove these (the _html.test
> tests) anyway.

What do you mean by "ignore"? I think we do still want to support this for
dart2js, at least for now. Do you mean I can just leave it as-is?

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1311: String get scriptType {
On 2017/07/19 14:13:07, Bill Hesse wrote:
> This function can be replaced with 'text/javascript', and places using it can
be
> simplified.

Done.

https://codereview.chromium.org/2981223002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1724: 
On 2017/07/19 14:13:06, Bill Hesse wrote:
> I think everything after this is dead code.  There is no dartc anymore.  No
code
> refers to these classes.

I believe AnalyzeLibraryTestSuite is still used for the "analyze_library"
selector, and it uses DartcCompilationTestSuite as its base class. The two
classes should be merged. Added a TODO.

[siva, 2017-07-20 00:33:52]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-07-20 00:33:52]

DBC

https://codereview.chromium.org/2981223002/diff/20001/tools/testing/dart/runt...
File tools/testing/dart/runtime_updater.dart (right):

https://codereview.chromium.org/2981223002/diff/20001/tools/testing/dart/runt...
tools/testing/dart/runtime_updater.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
Nit! 2017

[Bob Nystrom, 2017-07-20 19:42:26]

https://codereview.chromium.org/2981223002/diff/20001/tools/testing/dart/runt...
File tools/testing/dart/runtime_updater.dart (right):

https://codereview.chromium.org/2981223002/diff/20001/tools/testing/dart/runt...
tools/testing/dart/runtime_updater.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2017/07/20 00:33:52, siva wrote:
> Nit! 2017

Done.

[Bob Nystrom, 2017-07-20 19:46:54]

Description was changed from

==========
Remove Dartium support from test.dart.
==========

to

==========
Remove Dartium support from test.dart.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/012774c78e086d650ad0731cd5de48a04afaf7d0
==========

[Bob Nystrom, 2017-07-20 19:46:55]

Committed patchset #4 (id:60001) manually as
012774c78e086d650ad0731cd5de48a04afaf7d0.