Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: runtime/vm/dart.cc

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)
Patch Set: Remove flag support_debugger Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index 43ba92e1f1379bbd825ccb9df8eda352241c4265..d61096f39aa88964d84da9b4994f1d9a6eabc3bd 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -617,9 +617,10 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_data,
}
ServiceIsolate::SendIsolateStartupMessage();
- if (FLAG_support_debugger) {
- I->debugger()->NotifyIsolateCreated();
- }
+#if !defined(PRODUCT)
+ I->debugger()->NotifyIsolateCreated();
+#endif
+
// Create tag table.
I->set_tag_table(GrowableObjectArray::Handle(GrowableObjectArray::New()));
// Set up default UserTag.
@@ -646,10 +647,6 @@ const char* Dart::FeaturesString(Isolate* isolate, Snapshot::Kind kind) {
#endif
if (Snapshot::IncludesCode(kind)) {
- if (FLAG_support_debugger) {
- buffer.AddString(" support-debugger");
- }
-
// Checked mode affects deopt ids.
#define ADD_FLAG(name, isolate_flag, flag) \
do { \
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698