Remove the debugger_ field from Isolate in a PRODUCT build

runtime/vm/runtime_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/runtime_entry.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 752 matching lines @@
 }
 
 // Result of an invoke may be an unhandled exception, in which case we
 // rethrow it.
 static void CheckResultError(const Object& result) {
   if (result.IsError()) {
     Exceptions::PropagateError(Error::Cast(result));
   }
 }
 
-#if !defined(TARGET_ARCH_DBC)
+#if defined(PRODUCT)
+DEFINE_RUNTIME_ENTRY(BreakpointRuntimeHandler, 0) {
+  UNREACHABLE();
+  return;
+}
+#elif !defined(TARGET_ARCH_DBC)
 // Gets called from debug stub when code reaches a breakpoint
 // set on a runtime stub call.
 DEFINE_RUNTIME_ENTRY(BreakpointRuntimeHandler, 0) {
-  if (!FLAG_support_debugger) {
-    UNREACHABLE();
-    return;
-  }
   DartFrameIterator iterator(thread,
                              StackFrameIterator::kNoCrossThreadIteration);
   StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   const Code& orig_stub = Code::Handle(
       zone, isolate->debugger()->GetPatchedStubAddress(caller_frame->pc()));
   const Error& error =
       Error::Handle(zone, isolate->debugger()->PauseBreakpoint());
   if (!error.IsNull()) {
     Exceptions::PropagateError(error);
     UNREACHABLE();
   }
   arguments.SetReturn(orig_stub);
 }
 #else
 // Gets called from the simulator when the breakpoint is reached.
 DEFINE_RUNTIME_ENTRY(BreakpointRuntimeHandler, 0) {
-  if (!FLAG_support_debugger) {
-    UNREACHABLE();
-    return;
-  }
   const Error& error = Error::Handle(isolate->debugger()->PauseBreakpoint());
   if (!error.IsNull()) {
     Exceptions::PropagateError(error);
     UNREACHABLE();
   }
 }
 #endif  // !defined(TARGET_ARCH_DBC)
 
 DEFINE_RUNTIME_ENTRY(SingleStepHandler, 0) {
-  if (!FLAG_support_debugger) {
-    UNREACHABLE();
-    return;
-  }
+#if defined(PRODUCT)
+  UNREACHABLE();
+  return;
+#else
   const Error& error =
       Error::Handle(zone, isolate->debugger()->PauseStepping());
   if (!error.IsNull()) {
     Exceptions::PropagateError(error);
     UNREACHABLE();
   }
+#endif
 }
 
 // An instance call of the form o.f(...) could not be resolved.  Check if
 // there is a getter with the same name.  If so, invoke it.  If the value is
 // a closure, invoke it with the given arguments.  If the value is a
 // non-closure, attempt to invoke "call" on it.
 static bool ResolveCallThroughGetter(const Instance& receiver,
                                      const Class& receiver_class,
                                      const String& target_name,
                                      const Array& arguments_descriptor,
@@ skipping 853 matching lines @@
     JSONStream js;
     // Maybe adjust the rate of future reloads.
     isolate->MaybeIncreaseReloadEveryNStackOverflowChecks();
     // Issue a reload.
     bool success = isolate->ReloadSources(&js, true /* force_reload */);
     if (!success) {
       FATAL1("*** Isolate reload failed:\n%s\n", js.ToCString());
     }
 #endif
   }
-  if (FLAG_support_debugger && do_stacktrace) {
+#if !defined(PRODUCT)
+  if (do_stacktrace) {
     String& var_name = String::Handle();
     Instance& var_value = Instance::Handle();
     // Collecting the stack trace and accessing local variables
     // of frames may trigger parsing of functions to compute
     // variable descriptors of functions. Parsing may trigger
     // code execution, e.g. to compute compile-time constants. Thus,
     // disable FLAG_stacktrace_every during trace collection to prevent
     // recursive stack trace collection.
     intptr_t saved_stacktrace_every = FLAG_stacktrace_every;
     FLAG_stacktrace_every = 0;
@@ skipping 11 matching lines @@
       TokenPosition unused = TokenPosition::kNoSource;
       for (intptr_t v = 0; v < num_vars; v++) {
         frame->VariableAt(v, &var_name, &unused, &unused, &unused, &var_value);
       }
     }
     if (FLAG_stress_async_stacks) {
       Debugger::CollectAwaiterReturnStackTrace();
     }
     FLAG_stacktrace_every = saved_stacktrace_every;
   }
+#endif  // !defined(PRODUCT)
 
   const Error& error = Error::Handle(thread->HandleInterrupts());
   if (!error.IsNull()) {
     Exceptions::PropagateError(error);
     UNREACHABLE();
   }
 
   if ((stack_overflow_flags & Thread::kOsrRequest) != 0) {
     ASSERT(isolate->use_osr());
     DartFrameIterator iterator(thread,
@@ skipping 629 matching lines @@
     true /* is_float */,
     reinterpret_cast<RuntimeFunction>(static_cast<UnaryMathCFunction>(&tan)));
 
 DEFINE_RAW_LEAF_RUNTIME_ENTRY(
     LibcAtan,
     1,
     true /* is_float */,
     reinterpret_cast<RuntimeFunction>(static_cast<UnaryMathCFunction>(&atan)));
 
 }  // namespace dart