Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: runtime/lib/stacktrace.cc

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)
Patch Set: Remove flag support_debugger Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/developer.cc ('k') | runtime/vm/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "lib/stacktrace.h" 5 #include "lib/stacktrace.h"
6 #include "vm/bootstrap_natives.h" 6 #include "vm/bootstrap_natives.h"
7 #include "vm/debugger.h" 7 #include "vm/debugger.h"
8 #include "vm/exceptions.h" 8 #include "vm/exceptions.h"
9 #include "vm/native_entry.h" 9 #include "vm/native_entry.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 } 103 }
104 104
105 DEFINE_NATIVE_ENTRY(StackTrace_current, 0) { 105 DEFINE_NATIVE_ENTRY(StackTrace_current, 0) {
106 return CurrentStackTrace(thread, false); 106 return CurrentStackTrace(thread, false);
107 } 107 }
108 108
109 DEFINE_NATIVE_ENTRY(StackTrace_asyncStackTraceHelper, 1) { 109 DEFINE_NATIVE_ENTRY(StackTrace_asyncStackTraceHelper, 1) {
110 if (!FLAG_causal_async_stacks) { 110 if (!FLAG_causal_async_stacks) {
111 return Object::null(); 111 return Object::null();
112 } 112 }
113 113 #if !defined(PRODUCT)
114 GET_NATIVE_ARGUMENT(Closure, async_op, arguments->NativeArgAt(0)); 114 GET_NATIVE_ARGUMENT(Closure, async_op, arguments->NativeArgAt(0));
115 if (FLAG_support_debugger) { 115 Debugger* debugger = isolate->debugger();
116 Debugger* debugger = isolate->debugger(); 116 if (debugger != NULL) {
117 if (debugger != NULL) { 117 debugger->MaybeAsyncStepInto(async_op);
118 debugger->MaybeAsyncStepInto(async_op);
119 }
120 } 118 }
119 #endif
121 return CurrentStackTrace(thread, true); 120 return CurrentStackTrace(thread, true);
122 } 121 }
123 122
124 DEFINE_NATIVE_ENTRY(StackTrace_clearAsyncThreadStackTrace, 0) { 123 DEFINE_NATIVE_ENTRY(StackTrace_clearAsyncThreadStackTrace, 0) {
125 thread->clear_async_stack_trace(); 124 thread->clear_async_stack_trace();
126 return Object::null(); 125 return Object::null();
127 } 126 }
128 127
129 DEFINE_NATIVE_ENTRY(StackTrace_setAsyncThreadStackTrace, 1) { 128 DEFINE_NATIVE_ENTRY(StackTrace_setAsyncThreadStackTrace, 1) {
130 if (!FLAG_causal_async_stacks) { 129 if (!FLAG_causal_async_stacks) {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 AppendFrames(code_list, pc_offset_list, skip_frames); 172 AppendFrames(code_list, pc_offset_list, skip_frames);
174 const Array& code_array = Array::Handle(Array::MakeFixedLength(code_list)); 173 const Array& code_array = Array::Handle(Array::MakeFixedLength(code_list));
175 const Array& pc_offset_array = 174 const Array& pc_offset_array =
176 Array::Handle(Array::MakeFixedLength(pc_offset_list)); 175 Array::Handle(Array::MakeFixedLength(pc_offset_list));
177 const StackTrace& stacktrace = 176 const StackTrace& stacktrace =
178 StackTrace::Handle(StackTrace::New(code_array, pc_offset_array)); 177 StackTrace::Handle(StackTrace::New(code_array, pc_offset_array));
179 return stacktrace; 178 return stacktrace;
180 } 179 }
181 180
182 } // namespace dart 181 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/developer.cc ('k') | runtime/vm/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698