Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: runtime/vm/dart.cc

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 is_kernel_isolate = KernelIsolate::IsKernelIsolate(I); 610 is_kernel_isolate = KernelIsolate::IsKernelIsolate(I);
611 #endif 611 #endif
612 ServiceIsolate::MaybeMakeServiceIsolate(I); 612 ServiceIsolate::MaybeMakeServiceIsolate(I);
613 if (!ServiceIsolate::IsServiceIsolate(I) && !is_kernel_isolate) { 613 if (!ServiceIsolate::IsServiceIsolate(I) && !is_kernel_isolate) {
614 I->message_handler()->set_should_pause_on_start( 614 I->message_handler()->set_should_pause_on_start(
615 FLAG_pause_isolates_on_start); 615 FLAG_pause_isolates_on_start);
616 I->message_handler()->set_should_pause_on_exit(FLAG_pause_isolates_on_exit); 616 I->message_handler()->set_should_pause_on_exit(FLAG_pause_isolates_on_exit);
617 } 617 }
618 618
619 ServiceIsolate::SendIsolateStartupMessage(); 619 ServiceIsolate::SendIsolateStartupMessage();
620 #if !defined(PRODUCT)
620 if (FLAG_support_debugger) { 621 if (FLAG_support_debugger) {
621 I->debugger()->NotifyIsolateCreated(); 622 I->debugger()->NotifyIsolateCreated();
622 } 623 }
624 #endif
625
623 // Create tag table. 626 // Create tag table.
624 I->set_tag_table(GrowableObjectArray::Handle(GrowableObjectArray::New())); 627 I->set_tag_table(GrowableObjectArray::Handle(GrowableObjectArray::New()));
625 // Set up default UserTag. 628 // Set up default UserTag.
626 const UserTag& default_tag = UserTag::Handle(UserTag::DefaultTag()); 629 const UserTag& default_tag = UserTag::Handle(UserTag::DefaultTag());
627 I->set_current_tag(default_tag); 630 I->set_current_tag(default_tag);
628 631
629 if (FLAG_keep_code) { 632 if (FLAG_keep_code) {
630 I->set_deoptimized_code_array( 633 I->set_deoptimized_code_array(
631 GrowableObjectArray::Handle(GrowableObjectArray::New())); 634 GrowableObjectArray::Handle(GrowableObjectArray::New()));
632 } 635 }
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 ASSERT(predefined_handles_ != NULL); 750 ASSERT(predefined_handles_ != NULL);
748 return predefined_handles_->handles_.IsValidScopedHandle(address); 751 return predefined_handles_->handles_.IsValidScopedHandle(address);
749 } 752 }
750 753
751 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 754 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
752 ASSERT(predefined_handles_ != NULL); 755 ASSERT(predefined_handles_ != NULL);
753 return predefined_handles_->api_handles_.IsValidHandle(handle); 756 return predefined_handles_->api_handles_.IsValidHandle(handle);
754 } 757 }
755 758
756 } // namespace dart 759 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698