add env var info to the diagnostics page

add env var info to the diagnostics page

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8b7e3ef7e429622fa82a1d4979e53ae19c52fd18

[devoncarew, 2017-07-17 15:40:37]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[devoncarew, 2017-07-17 15:40:37]

- add an Environment Variables section to the diagnostics page
- remove the display for the lint timing info - we're not enabling tracking the
lint timing, so all times show as 0 (added a TODO:)

[scheglov, 2017-07-17 16:14:40]

lgtm

[devoncarew, 2017-07-17 16:21:02]

Description was changed from

==========
add env var info to the diagnostics page

BUG=
==========

to

==========
add env var info to the diagnostics page

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8b7e3ef7e429622fa82a1d4979e53ae19c52fd18
==========

[devoncarew, 2017-07-17 16:21:05]

Committed patchset #1 (id:1) manually as
8b7e3ef7e429622fa82a1d4979e53ae19c52fd18 (presubmit successful).

[Brian Wilkerson, 2017-07-19 21:51:09]

lgtm

https://codereview.chromium.org/2981123002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2981123002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:1030: final bool _showLints
= false;
It would be nice to be able to see the timing information when it exists, rather
than permanently disabling it.

[devoncarew, 2017-07-19 22:02:13]

https://codereview.chromium.org/2981123002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2981123002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:1030: final bool _showLints
= false;
On 2017/07/19 21:51:09, Brian Wilkerson wrote:
> It would be nice to be able to see the timing information when it exists,
rather
> than permanently disabling it.

I don't think it's ever enabled in the context of the analysis server though? I
think that flag only gets flipped when run from the CLI?

Happy to update this if there's something I should be checking at runtime.