Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2980973003: Default value constants are created only call uses them (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Default value constants are created only call uses them Currently this fails with: Unhandled exception: Expect.fail('Instantiated types mismatch: Unfound: _Marker') The generated code also contains the class and the (unused) constant. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/a433bfd3b33ccaa61c050e830ccf34a225254a61

Patch Set 1 #

Patch Set 2 : register default values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 3 chunks +35 lines, -1 line 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 2 chunks +20 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
Now passing.
3 years, 5 months ago (2017-07-18 23:08:09 UTC) #4
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-19 10:32:52 UTC) #5
sra1
3 years, 5 months ago (2017-07-19 17:35:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
a433bfd3b33ccaa61c050e830ccf34a225254a61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698