Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2980953002: Use entities in most of MirrorsData (part 2) (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -58 lines) Patch
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 12 chunks +71 lines, -57 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-14 13:06:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2980953002/diff/1/pkg/compiler/lib/src/js_backend/mirrors_data.dart File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right): https://codereview.chromium.org/2980953002/diff/1/pkg/compiler/lib/src/js_backend/mirrors_data.dart#newcode516 pkg/compiler/lib/src/js_backend/mirrors_data.dart:516: bool isClassInjected(ClassEntity cls) => false; might be nice ...
3 years, 5 months ago (2017-07-14 17:52:04 UTC) #3
Johnni Winther
https://codereview.chromium.org/2980953002/diff/1/pkg/compiler/lib/src/js_backend/mirrors_data.dart File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right): https://codereview.chromium.org/2980953002/diff/1/pkg/compiler/lib/src/js_backend/mirrors_data.dart#newcode516 pkg/compiler/lib/src/js_backend/mirrors_data.dart:516: bool isClassInjected(ClassEntity cls) => false; On 2017/07/14 17:52:04, Siggi ...
3 years, 5 months ago (2017-07-17 09:07:20 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-17 09:29:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
94405484b4871bf0e77d676f467a7c7fc1bbd91f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698