Issue 2980933002: DO NOT SUBMIT, Uglify print preview resources, WIP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980933002: DO NOT SUBMIT, Uglify print preview resources, WIP.

Created:
3 years, 5 months ago by dpapad

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, arv+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DO NOT SUBMIT, Uglify print preview resources, WIP. Reduces browser_resources.pak file from 2.8mb to 2.5mb BUG=

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -1 line)			Patch
M	chrome/browser/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+8 lines, -1 line	0 comments	Download
A	chrome/browser/resources/print_preview/BUILD.gn	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/uglify_gn.py	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/vulcanize.gni	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dpapad

Description was changed from ========== DO NOT SUBMIT, Uglify print preview resources, WIP. BUG= ========== ...

3 years, 5 months ago (2017-07-14 00:30:20 UTC) #1

dpapad

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

3 years, 5 months ago (2017-07-14 01:59:06 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980933002/1

3 years, 5 months ago (2017-07-14 01:59:22 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 5 months ago (2017-07-14 02:15:45 UTC) #4

commit-bot: I haz the power

3 years, 5 months ago (2017-07-14 02:15:46 UTC) #5

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages