Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: Source/platform/graphics/media/MediaPlayer.h

Issue 298093004: Eliminate MediaPlayer & MediaPlayerClient abstractions(play/pause, other APIs) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/media/MediaPlayer.h
diff --git a/Source/platform/graphics/media/MediaPlayer.h b/Source/platform/graphics/media/MediaPlayer.h
index a4d7ccdcac9f7590937e4603dd97d7403416489c..fd5bcb7ff9d829f73891ff66d576c6add303e710 100644
--- a/Source/platform/graphics/media/MediaPlayer.h
+++ b/Source/platform/graphics/media/MediaPlayer.h
@@ -112,11 +112,6 @@ public:
virtual void load(blink::WebMediaPlayer::LoadType, const String& url, blink::WebMediaPlayer::CORSMode) = 0;
- virtual void play() = 0;
- virtual void pause() = 0;
-
- virtual bool supportsSave() const = 0;
-
virtual double duration() const = 0;
virtual double currentTime() const = 0;
@@ -128,8 +123,6 @@ public:
virtual double rate() const = 0;
virtual void setRate(double) = 0;
- virtual bool paused() const = 0;
-
virtual void setPoster(const KURL&) = 0;
enum NetworkState { Empty, Idle, Loading, Loaded, FormatError, NetworkError, DecodeError };
@@ -149,12 +142,6 @@ public:
enum Preload { None, MetaData, Auto };
virtual void setPreload(Preload) = 0;
- virtual bool hasSingleSecurityOrigin() const = 0;
-
- // Time value in the movie's time scale. It is only necessary to override this if the media
- // engine uses rational numbers to represent media time.
- virtual double mediaTimeForTimeValue(double timeValue) const = 0;
-
#if ENABLE(WEB_AUDIO)
virtual AudioSourceProvider* audioSourceProvider() = 0;
#endif
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698